search

Shock95 / AuctionHouse

Feature-packed auction house plugin for PocketMine-MP (pmmp)
GNU General Public License v3.0
43 stars 35 forks source link

feature suggestion & bug Report #4

Closed TheUtopianPlayz closed 4 years ago

TheUtopianPlayz commented 4 years ago

use UUID for storage instead of the player name

would help a lot in case sensitive issues and issues where people use plugins like jackMD's namespaceremover plugin that swaps spaces in names with underscores

TheUtopianPlayz commented 4 years ago

heres the error that goes along with my feature suggestion

**[Server thread/CRITICAL]: ErrorException: "include(phar:///home/p2e/factions/plugins/AuctionHouse_dev-7 (1).phar/src/shock95x/auctionhouse/auction/Listing.php): failed to open stream: phar error: Cannot open phar archive "/home/p2e/factions/plugins/AuctionHouse_dev-7 (1).phar" for reading" (EXCEPTION) in "vendor/pocketmine/spl/BaseClassLoader" at line 126 [00:44:29] [Server thread/DEBUG]: #0 vendor/pocketmine/spl/BaseClassLoader(126): pocketmine\utils\Utils::errorExceptionHandler(integer 2, string[246] include(phar:///home/p2e/factions/plugins/AuctionHouse_dev-7 (1).phar/src/shock9, string[86] phar:///home/p2e/factions/PocketMine-MP.phar/vendor/pocketmine/spl/BaseClassLoad, integer 126, array[2]) [00:44:29] [Server thread/DEBUG]: #1 vendor/pocketmine/spl/BaseClassLoader(126): include()

[00:44:29] [Server thread/DEBUG]: #3 plugins/AuctionHouse_dev-7 (1).phar/src/shock95x/auctionhouse/database/DataHolder(65): spl_autoload_call(string[37] shock95x\auctionhouse\auction\Listing) [00:44:29] [Server thread/DEBUG]: #4 plugins/AuctionHouse_dev-7 (1).phar/src/shock95x/auctionhouse/commands/AHCommand(96): shock95x\auctionhouse\database\DataHolder::addListing(object JackMD\NameSpaceRemover\CustomPlayer, integer 100, string[51] ...........b`b.La.gdu./.+adbsI.MLOe.f..&FNy....) [00:44:29] [Server thread/DEBUG]: #5 src/pocketmine/command/SimpleCommandMap(270): shock95x\auctionhouse\commands\AHCommand->execute(object JackMD\NameSpaceRemover\CustomPlayer, string[2] ah, array[2]) [00:44:29] [Server thread/DEBUG]: #6 src/pocketmine/Server(2026): pocketmine\command\SimpleCommandMap->dispatch(object JackMD\NameSpaceRemover\CustomPlayer, string[11] ah sell 100) [00:44:29] [Server thread/DEBUG]: #7 src/pocketmine/Player(2257): pocketmine\Server->dispatchCommand(object JackMD\NameSpaceRemover\CustomPlayer, string[11] ah sell 100) [00:44:29] [Server thread/DEBUG]: #8 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(245): pocketmine\Player->chat(string[12] /ah sell 100) [00:44:29] [Server thread/DEBUG]: #9 src/pocketmine/network/mcpe/protocol/CommandRequestPacket(54): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleCommandRequest(object pocketmine\network\mcpe\protocol\CommandRequestPacket) [00:44:29] [Server thread/DEBUG]: #10 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(111): pocketmine\network\mcpe\protocol\CommandRequestPacket->handle(object pocketmine\network\mcpe\PlayerNetworkSessionAdapter) [00:44:29] [Server thread/DEBUG]: #11 src/pocketmine/network/mcpe/protocol/BatchPacket(123): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(object pocketmine\network\mcpe\protocol\CommandRequestPacket) [00:44:29] [Server thread/DEBUG]: #12 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(111): pocketmine\network\mcpe\protocol\BatchPacket->handle(object pocketmine\network\mcpe\PlayerNetworkSessionAdapter) [00:44:29] [Server thread/DEBUG]: #13 src/pocketmine/Player(3158): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(object pocketmine\network\mcpe\protocol\BatchPacket) [00:44:29] [Server thread/DEBUG]: #14 src/pocketmine/network/mcpe/RakLibInterface(169): pocketmine\Player->handleDataPacket(object pocketmine\network\mcpe\protocol\BatchPacket) [00:44:29] [Server thread/DEBUG]: #15 vendor/pocketmine/raklib/src/server/ServerHandler(99): pocketmine\network\mcpe\RakLibInterface->handleEncapsulated(string[20] 47.217.148.174 64838, object raklib\protocol\EncapsulatedPacket, integer 0) [00:44:29] [Server thread/DEBUG]: #16 src/pocketmine/network/mcpe/RakLibInterface(109): raklib\server\ServerHandler->handlePacket() [00:44:29] [Server thread/DEBUG]: #17 src/pocketmine/network/mcpe/RakLibInterface(99): pocketmine\network\mcpe\RakLibInterface->process() [00:44:29] [Server thread/DEBUG]: #18 vendor/pocketmine/snooze/src/SleeperHandler(123): pocketmine\network\mcpe\RakLibInterface->pocketmine\network\mcpe{closure}() [00:44:29] [Server thread/DEBUG]: #19 vendor/pocketmine/snooze/src/SleeperHandler(85): pocketmine\snooze\SleeperHandler->processNotifications() [00:44:29] [Server thread/DEBUG]: #20 src/pocketmine/Server(2349): pocketmine\snooze\SleeperHandler->sleepUntil(double 1579671869.9152) [00:44:29] [Server thread/DEBUG]: #21 src/pocketmine/Server(2203): pocketmine\Server->tickProcessor() [00:44:29] [Server thread/DEBUG]: #22 src/pocketmine/Server(1785): pocketmine\Server->start() [00:44:29] [Server thread/DEBUG]: #23 src/pocketmine/PocketMine(272): pocketmine\Server->__construct(object BaseClassLoader, object pocketmine\utils\MainLogger, string[19] /home/p2e/factions/, string[27] /home/p2e/factions/plugins/) [00:44:29] [Server thread/DEBUG]: #24 src/pocketmine/PocketMine(295): pocketmine\server() [00:44:29] [Server thread/DEBUG]: #25 (1): require(string[74] phar:///home/p2e/factions/PocketMine-MP.phar/src/pocketmine/PocketMine.php)**

Shock95 commented 4 years ago

@TheUtopianPlayz I'll look into this issue, and this plugin does use UUID for storage

Shock95 commented 4 years ago

@TheUtopianPlayz Submit a crash report at https://crash.pmmp.io

TheUtopianPlayz commented 4 years ago

What I meant was if u use UUID storage instead of just the username it would completely avoid issues like this, because the name would have nothing to do with the issue, it would illuminate any errors on the subject and it would be a more reliable storage system

Shock95 commented 4 years ago

@TheUtopianPlayz Submit a crash report because I can't seem to replicate this issue.

TheUtopianPlayz commented 4 years ago

the error isnt important i just included it in case u needed it, im recommending to switch to UUID Instead of username to avoid any name related issues that could happen with plugins like NameSpaceRemover or with xbox live auth

long story short using UUID for storage instead of saving the username, would allow alot more people to use this plugin

Shock95 commented 4 years ago

@TheUtopianPlayz Does the error break the server or stop the plugin from functioning? If so then it's important and also the plugin stores both UUID's and usernames, the usernames are only used to display the names of people with their listings and for messages.

Shock95 commented 4 years ago

@TheUtopianPlayz If you submit a crash report I might be able to fix this because I'm not able to reproduce that error

TheUtopianPlayz commented 4 years ago

issue number 5 is a completely differ error i went ahead and got rid of NameSpaceremover cuz it causes problems with multiple other plugins on my server, i didnt submit a crash report for this error because it says its a invalid error on the site