search

Shock95 / AuctionHouse

Feature-packed auction house plugin for PocketMine-MP (pmmp)
GNU General Public License v3.0
43 stars 34 forks source link

Make sure all data gets stored on disable #46

Closed rjworks closed 4 years ago

rjworks commented 4 years ago

Make sure all data gets stored on disable

rjworks commented 4 years ago

any side effects if another plugin is also using libasynql and is saving data and has waitAll() in onDisable()?

Shock95 commented 4 years ago

It's already used here https://github.com/Shock95x/AuctionHouse/blob/388cb0bc7d1d83c83f398a1ae7c58991ce4e5fe0/src/shock95x/auctionhouse/database/Database.php#L111

Shock95 commented 4 years ago

I don't think there are any side effects to that also

rjworks commented 4 years ago

oh oops