search

Shopify / pyoozie

Library for querying and scheduling with Apache Oozie
https://py-oozie.readthedocs.io
MIT License
11 stars 12 forks source link

Fix missing test coverage in tags #9

Closed cfournie closed 7 years ago

cfournie commented 7 years ago

This increases the line test coverage to 100% for the tags module.

review/ @kmtaylor-github @honkfestival

kmtaylor-github commented 7 years ago 
# pylint: disable=abstract-method
class MyTag(XMLSerializable):
   ...
E       TypeError: Can't instantiate abstract class MyTag with abstract methods _xml

Sigh...

cfournie commented 7 years ago

Bah. Well I'll just call it another (erroneous) way then.

honkfestival commented 7 years ago

Jumping through hoops like this just for 100% coverage doesn't add much value. Is it possible to disable code coverage for these bits instead?

cfournie commented 7 years ago

Jumping through hoops like this just for 100% coverage doesn't add much value

True, but these aren't really hoops, they're legitimate tests of API functionality. I want to warn users loudly if they do something that's currently unsupported and I didn't test env vars or capture output at all.

honkfestival commented 7 years ago

they're legitimate tests of API functionality

Gotcha. From the PR description, I thought you were just chasing the 100. :)