search

Sid72020123 / scratchconnect

Python Library to connect Scratch API and much more.
https://sid72020123.github.io/scratchconnect/
MIT License
25 stars 14 forks source link

fixed and changed some stuff #40

Closed aidaner closed 2 years ago

aidaner commented 2 years ago

i changed the events to get updates from the websocket like the browsers do instead of sending a request to the api every time. but the websocket does not send the username or timestamp when a new change occurs so i replaced it with a None. i can revert this if you want. and i fixed the broken pipe error by making a new thread that pings the websocket so the server does not close the connection and the thread auto closes when the main script is done

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 9d230be951a826c32cf3c6b70516e91598d31b55 into 3ef863d1495da0ec4d598ed1054474298e4c367f - view on LGTM.com

new alerts:

Sid72020123 commented 2 years ago

Cool! I will merge this with next version but before that, I need to test this...

aidaner commented 2 years ago

ok

aidaner commented 2 years ago

ok. i will change it back

Sid72020123 commented 2 years ago

Thank you so much! I will test this and merge it. BTW What's your Scratch Username? I want that because I want to thank you in credits section of Readme...

aidaner commented 2 years ago

My scratch username is AidanER1

Sid72020123 commented 2 years ago

My scratch username is AidanER1

Thank you! I will add that username in credits...