search

Sid72020123 / scratchconnect

Python Library to connect Scratch API and much more.
https://sid72020123.github.io/scratchconnect/
MIT License
26 stars 14 forks source link

Possibly remove the `ForbiddenLogin` exception as it causes a lot of confusion #41

Closed Chiroyce1 closed 2 years ago

Chiroyce1 commented 2 years ago

(example: https://scratch.mit.edu/discuss/post/6336436/)

A lot of users think that there is an error in their code when they see an exception, and this happens a lot when ForbiddenLogin occurs, instead, how about a coloured print message that will calmly tell them how to fix it? Not the best idea, but I'm sure it'll reduce confusion and posts like the one above. We'll only add it for this one, since the others might be actual code related issues.

Sid72020123 commented 2 years ago

Ok! I will add that! It's simple! Just use ANSI escape sequences... It may take much time for me to update because I am busy (being promoted to 10th grade)

Chiroyce1 commented 2 years ago

Do you want me make a PR? I can do it with plain ANSI sequences, and without requiring any extra dependencies.

Sid72020123 commented 2 years ago

Thank you! but no need for a PR as I can do that when I get time. It's not a serious bug as some experienced people understand that message. Yes, I will add plain ANSI Escape Sequences.

Chiroyce1 commented 2 years ago

@Sid72020123 Ok! It isn't very important so you can take your time, I just presented the idea.

Sid72020123 commented 2 years ago

Ok. Thank you! Great Idea! I will try to add this soon...

Sid72020123 commented 2 years ago

Ok. I added this in version 3.4. So I will close this now...

Chiroyce1 commented 2 years ago

@CubeyTheCube I see that you've disliked my comment - do you mind telling why?

Sid72020123 commented 2 years ago

Because I talked to them on other platforms and they said that they hate Scratch. Maybe because they are banned?