search

SignalK / signalk-server-java

DEPRECATED - see https://github.com/SignalK/signalk-java
Apache License 2.0
6 stars 9 forks source link

Failing tests #11

Closed jboynes closed 8 years ago

jboynes commented 8 years ago

Trying to build 959c8d0cee08ae3599f257fdbbd4591985857ded I am getting failures from the following tests:

I noticed cd0952244c9ac295b39d6b99ccdcf9a2cc705956 mentions two unreliable tests - are the those the first two above?

printKeys fails because of a hard coded reference to /home/robert/gitrep which I can patch but I don't see what that test is actually asserting. Is the output used somehow or can this be deleted/ignored/converted to a command utility?

rob42 commented 8 years ago

Yes they work normally when run individually, but fail in the maven build. I cant find the cause - presumably some sort of dirty context from other tests? The last one (GetSignalkKeysTest#printKeys) is used to generate SignalkConstants lines from the current specification jsonschema. It should be marked @Ignore

I have a big commit to do today, which will fix some of the above.

rob42 commented 8 years ago

Fixed now, so closing this

jboynes commented 8 years ago

These are still failing for me:

Failed tests:   shouldCreateInstantDelta(nz.co.fortytwo.signalk.processor.FullExportProcessorTest): 1:MapSizeAfter != queue size expected:<0> but was:<1>
  shouldUnSubscribeOne(nz.co.fortytwo.signalk.processor.JsonSubscribeProcessorTest): expected:<2> but was:<3>
rob42 commented 8 years ago

Yes me too - immediately after I closed this :-(

jboynes commented 8 years ago

Two PR's for this:

20 to fix FullExportProcessor

21 to fix JsonSubscribeProcessorTest

rob42 commented 8 years ago

Closing, all tests working reliably now