search

SignalK / signalk-server-java

DEPRECATED - see https://github.com/SignalK/signalk-java
Apache License 2.0
6 stars 9 forks source link

Do not store the compiled binary in Git #22

Closed jboynes closed 8 years ago

jboynes commented 8 years ago

Although it's handy for people who just checkout out the repo, this clutters the repo history with large binary artifacts.

We should distribute this for users by publishing to a SNAPSHOT repo somewhere, or using alternative packaging like a Docker image.

rob42 commented 8 years ago

As you say it was done to make things easier for noobs, just git clone and run. Otherwise it requires maven, jdk and build process etc. I am struggling with the workload now, and didnt want to complicate the project with two repos. But the bin image is a valid consideration. Wonder if its possible to automate it with a module or artifactory like integration?

jboynes commented 8 years ago

Opened #24 to set up automated distribution. I think we should stop checking the binary in anyway as it will rapidly bloat the size of the repo (a full copy it stored as part of every commit).

rob42 commented 8 years ago

Ive changed the project to use jitpack.io which is a shortcut and more flexible way of doing maven releases. This means the all-in-one jar not be commited anymore. Leaving the existing history so we dont disturb other forks.

rob42 commented 8 years ago

Just realised there are other changes bundled in here - still need to go through them.

rob42 commented 8 years ago

jitpack.io is working now which negates the need for the binaries to be stored in git. Most other changes (except travis) have been merged into the master separately, so closing this. Pls add another separate travis pull request if required.