SignalK / signalk-server-java

DEPRECATED - see https://github.com/SignalK/signalk-java
Apache License 2.0
6 stars 9 forks source link

`/signalk` returning weird version output #40

Closed ph1l closed 7 years ago

ph1l commented 7 years ago

Looks like there is a bug in the endpoints data. (http://signalk.org/specification/master/urls_etc.html#versioning)

elektron@x61s:~/code/python-signalk-client$ curl -s http://localhost:8080/signalk | jq .
{
  "endpoints": {
    "1.": {
      "signalk-tcp": "tcp://localhost:55555",
      "signalk-udp": "udp://localhost:55554",
      "nmea-tcp": "tcp://localhost:55557",
      "nmea-udp": "udp://localhost:55556",
      "signalk-http": "http://localhost:8080/signalk/v1/api/",
      "mqtt": "mqtt://localhost:1883",
      "signalk-ws": "ws://localhost:3000/signalk/v1/stream",
      "stomp": "stomp+nio://localhost:61613",
      "version": ".0.0"
    }
  }
}
rob42 commented 7 years ago

Its an artifact of the old version number, which included the 'v', eg v1.0.0. The code truncates the the wrong bits now. Fixing

rob42 commented 7 years ago

Fixed in JIT-Deploy-34