search

SignalK / signalk-server-java

DEPRECATED - see https://github.com/SignalK/signalk-java
Apache License 2.0
6 stars 9 forks source link

Change handling of depth data #41

Closed RBerliner closed 7 years ago

RBerliner commented 7 years ago

Correcting bugs in handling depth data

DepthProcessor.java
Get data from singnal/kModel directly instead of Exchange

SignalKRouteFactory.java
Removed DepthProcessor from configureInputRoute.

Added pomDev.xml
Will do dev build by default.
RBerliner commented 7 years ago

Hi Phil:

The commit of output.txt is a mistake - until your email I did not realize it was in there. I will submit a PR to remove it.

The file NeutronDance.log can be trimmed but I am currently using it for tests with my laptop (using localhost) and on the RPi.

The file is not required for the depth changes but provides a stream of depth data (from a freeboard source) for testing. At the moment it is quite useful.

Ron

On Mon, Apr 10, 2017 at 1:16 PM, Philip Freeman notifications@github.com wrote:

@ph1l commented on this pull request.

I think you should re-submit this PR without including output.txt, this will just bloat the git repo. (362K)

In the same vein, is the large file, src/test/resources/samples/ NeutronDance.log (2.6M), related to or required for your depth changes? Can it be trimmed to a bare minimum required for the test to be performed?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SignalK/signalk-server-java/pull/41#pullrequestreview-31903788, or mute the thread https://github.com/notifications/unsubscribe-auth/ADgpSdOq0wyi0AGF-APkK14i_qALszhXks5rumPXgaJpZM4M3Ix- .

--

R. Berliner Instrumentation Associates 101 Echowood Ln Cary, NC 27518

e-mail: rberliner@InstrumentationAssociates.com

www.InstrumentationAssociates.com http://www.InstrumntationAssociates.com

Tel 734-646-5318

rob42 commented 7 years ago

Not sure if you are aware but in eclipse you can right-click a file and 'ignore' it for git. Netbeans must have a similar feature. It adds an entry in the hidden .gitignore file. So by adding misc files and dirs they dont get accidentally committed. But I find your log file useful - I can see what you are up too...

ph1l commented 7 years ago

fair enough.

just my $0.02 :-)

ph1l commented 7 years ago

BTW, if you merge the branch w/o a "squash" merge, the removed file will still be included in master's history.

consider force pushing a branch to clean up your commit history..

rob42 commented 7 years ago

Closing as this has been adjusted and merged separately