search

SijuKJ / desktopoauth2.0

MIT License
5 stars 2 forks source link

feat(dependencies & code verification): specify latest versions and add client_secret #5

Closed sjoulbak closed 8 months ago

sjoulbak commented 8 months ago

Hey @SijuKJ 👋

Thanks for creating this solution. We've made an internal Flutter desktop tool, that needs multiple Oauth2 authorizations. Previously I used a similar solution, but then by using flutter_inappwebview. We had to search for different solution, because some of our users want to use the tool on Linux. And thats what your solution seems to resolve 👌

In this PR I changed the versions of a url_launcher and http to its latest version. Especially for http it will make sense, because in the past 14 months it released a new major version.

Secondly, I added client_secret to the code verification part for when pkce is set to false. This was necessary at every implementation what I saw.

sjoulbak commented 8 months ago

Thanks @SijuKJ 🤗

About releasing the package, I see that there are a lot of analysis issues with the latest release. Do you have time to resolve those? It would be nice to have the package scoring good at pub.dev 🚀

Another thing, are you open in having a github actions flow, which creates a release after a trigger?