search

SilentCog / rpgjs

Easter egg console.log game in the text based RPG fashion.
https://silentcog.github.io/console-game/
5 stars 2 forks source link

Replace jQuery dependency with native functionality #29

Closed mimiflynn closed 9 years ago

SandyGifford commented 9 years ago

Any reason for this?

mimiflynn commented 9 years ago

Its just a heavy library for such little use. It could be easily replaced with native JS.

SandyGifford commented 9 years ago

In addition to the element selecting, it's also being used to animate the scroll for new lines. Nothing we couldn't write on our own, still, I guess.

mimiflynn commented 9 years ago

On second thought, and I know this goes against what I said about heavy libraries, I want to make it an isomorphic React component because it can be a great example for a talk I've been working on.

SandyGifford commented 9 years ago

Are you going to be designing your own isomorphic system? Or do you have a module I should start reading up on?

mimiflynn commented 9 years ago

Rolling my own. Kinda.

It's really just using the same code to render server side as client side so I just need to render with a react component on the server then initialize with the same code on the client. It's already working for the game selector on my branch. Almost done with the game play area.

I can walk you through it later. It would be really helpful to discuss it with you for the talk.

On Oct 20, 2015, at 6:57 AM, Sandy Gifford notifications@github.com wrote:

Are you going to be designing your own isomorphic system? Or do you have a module I should start reading up on?

— Reply to this email directly or view it on GitHub.

SandyGifford commented 9 years ago

Sounds good. I'd love to hear about it. I'm glad to hear the switcher made the transition no problem.