Add support for ARM64 architecture

Silverpeas / docker-silverpeas-prod

A project to build a docker image of Silverpeas ready for production

GNU General Public License v3.0

3 stars 5 forks source link

Add support for ARM64 architecture #2

Closed odidev closed 6 years ago

odidev commented 6 years ago

Silverpeas is building and running fine on arm64v8 architecture as well. The only issue was due to the hard-coded JAVA_HOME environment variable.

Once this is fixed, silverpeas is good to run on multiple platforms.

Regards,

mmoqui commented 6 years ago

What is wrong in the PR:

the change isn't restricted to only the ARM64 or AMD64 architecture: no control on the supported architecture.
the Docker image for ARM64 architecture can only be built onto an ARM64 machine (as the targeted architecture is detected during the build)
the change is done directly into the Dockerfile instead of the Dockerfile.template from which the Dockerfile is generated with the generate-dockerfile.sh script.

odidev commented 6 years ago

Hi @mmoqui Thanks for providing your time to review the PR.

Can you please guide, what can be the best way to add support for arm64 for silverpeas. Will modification in Dockerfile.template be sufficient enough?

Regards,

odidev commented 6 years ago

Hi @mmoqui

Regarding no control on the supported architecture I think supported architecture will be shown on the Docker Official library page of Silverpeas, which will just show support for amd64 & arm64v8 architectures. This will inform everyone that SilverPeas is supporting just mentioned architectures, so if someone tries to build it over other architectures then it will be his own responsibility.
- Regarding targeted architecture is detected during the build In my view, this is what is happening for all multi-architecture supported docker modules. Detect the architecture at runtime, if it is suppported then proceed ahead otherwise return a failure.

Regards,

odidev commented 6 years ago

Updated this PR with the suggestions provided above.

The user needs to run below command to generate a new dockerfile

For arm64 architecture $generate-dockerfile.sh 6.0.1 10.1.0 arm64
For amd64 architecture $generate-dockerfile.sh 6.0.1 10.1.0 amd64

The above commands will generate Dockerfile for either AMD64 or ARM64 based on architecture provided in generate-dockerfile.sh

Regards,

odidev commented 6 years ago

Hi @tianon ,

Thanks for reviewing the changes and providing the solution too :smile: I also agree with your concern regarding maintaining multiple Dockerfiles just for the sake of an environment variable with architecture specific path.

I will surely get back with updated PR, with the architecture check at runtime.

Regards,

odidev commented 6 years ago

Hi @tianon

I have updated this PR with your suggested changes. The changes are working very well on both amd64 and arm64 architectures.

BTW, thanks again for your suggestion :smile:

Regards,