SimaticResearchActivity / FBAE

Framework for Broadcast Algorithms Evaluation
GNU Affero General Public License v3.0
0 stars 1 forks source link

Improve usage of Cereal polymorphic capabilities #55

Closed simatic closed 6 months ago

simatic commented 6 months ago

Usage of Cereal polymorphic capabilities can be improved in 3 ways:

  1. Find a solution why polymorphic overhead is currently 22 bytes while it should be only 8 bytes. This is because Cereal stores name of serialized types SessionPerf and SessionTest as a string into the resulting string. For the moment, we did not find why Cereal does that.
  2. SessionLayerMsg.h contains compilation warnings "Function 'serialize' hides a non-virtual function from struct 'SessionBaseClass' that should be removed.
  3. Current code uses shared_ptr. Using unique_ptr would be more efficient.