search

SimaticResearchActivity / FBAE

Framework for Broadcast Algorithms Evaluation
GNU Affero General Public License v3.0
0 stars 1 forks source link

Transfer multicast address used for tests from Arguments class to test class #69

Open simatic opened 5 months ago

simatic commented 5 months ago

In aPull request, SonarQube triggers warning "Make sure using this hardcoded IP address is safe here." (cpp:S1313) because we define:

 auto networkLevelMulticastAddressForTests{"239.255.0.1"};

in Arguments.cpp.

It would be cleaner to define this value only in test class TcpTest.cpp.