SirPlease / L4D2-Competitive-Rework

Just refreshing and optimizing the core files a bit, eh?
GNU General Public License v3.0
248 stars 134 forks source link

Jockey airstuck exploit #247

Closed lunatixxx closed 3 years ago

lunatixxx commented 3 years ago

How often does it happen on your servers ? This thing is annoying and it is impossible to differenciate if this is was a bug or if it was from cheats. Sometimes nothing will happen for a dozen of games then suddenly for two games in a row it will happen at least once, usually with suspect profiles but it happens more and more often with legit player it seems recently.

While this plugin (https://forums.alliedmods.net/showpost.php?p=2730524&postcount=26) fix partially the problem by teleporting back the survivor to his original position there are still a few maps that can't be fixed with it.

SirPlease commented 3 years ago

I've commented on this multiple times, I've never seen it happen on my own servers nor have I gotten reports about it. When trying to troubleshoot the problem with people they'd always admit to having added files or modified existing plugins, so there isn't much I can do in that case.

lunatixxx commented 3 years ago

There were multiple reports that it happens too on official servers, personally i can't verify as i'm not playing on these since a long time. By the way i did test without plugins who could be problematic (bhap blocker and other jockeys related plugins), it still happened in the end.

https://github.com/ValveSoftware/Source-1-Games/issues/3454 (i don't expect valve to do anything but for the record at least)

A1mDev commented 3 years ago

+1, this did not happen on my servers, maybe you have a lot of cheaters. This happens when the player uses tickbase manipulation. Try writing a plugin to detect this. (netprop m_nTickBase)

Derpduck commented 3 years ago

Something similar to the videos in that link can also happen without cheats if a player that is about to become a tank (by passing or tank spawning) caps a survivor with a jockey, but I've only ever seen this on Valve servers.

lunatixxx commented 3 years ago

I don't know the other day this was a jockey bot who teleported the human survivor, not sure why it will be intended when they are winning. It can be exploited surely but nothing seems to detect it. Also this looks like the fake charger bug that happened when players were joining or leaving (mainly in scavenge but sometimes in versus), who seems fixed since Last Stand.

A1mDev commented 3 years ago

You talk about charger ghost bug? This is fixed after update yes. This bug occurred when the infected or survivor player died while carry the charger. This could be easily fixed using the player_death event and netprops m_hQuenePummelVictim (i don't remember exactly the name, but it is not in the documentation, this is a hidden netprop). It's a little different, not related to cheats.

A1mDev commented 3 years ago

This netprop is pretty much the same as m_pummelVictim and it didn't reset itself. This was heavily influenced by trigger_hurt, which killed just by carrying the charger. And very often this bug could be seen in the cleaning mode. And this happened during the player's exit, when the surviving player is replaced by a bot, there were no other cases.

A1mDev commented 3 years ago

I know such a mistake when a spawned infected person gets a tank, and when the tank appears, he leaves the game or changes the team, then the tank moves to coordinates 0 0 0, and the infected person gets the opportunity to get into the tank and also gets 6000 hp. But this is due to the CTerrorPlayer :: ReplaceWithBot function, which is receiving the wrong coordinates. It seems the Derpduck is talking about it. And what is wrong in your case, I can't even imagine. Why is the jockey teleporting to zero coordinates?)

lunatixxx commented 3 years ago

I don't know but this thing happens mostly since Last Stand update for me, i only saw it once before on my server before the update and the player was detected by SMAC. Now at least every game it will happen and nothing. I'm using the same plugins that this repository, so i don't think this is what cause the problem.

SirPlease commented 3 years ago

I'll close this issue, because it doesn't have to do with the rework in the first place and I'm unable to reproduce the issue as I've never seen it happen on my own servers (that run the same plugins along with additional ones) or have had it reported on my servers.

ProjectSky commented 3 years ago

I suggest reopen this issue