SirPlease / L4D2-Competitive-Rework

Just refreshing and optimizing the core files a bit, eh?
GNU General Public License v3.0
231 stars 125 forks source link

[BUG]There is an issue with l4d2_weapon_attributes.smx or confoglcompmod.smx #739

Open NanakaFathry opened 4 months ago

NanakaFathry commented 4 months ago

Describe the bug (Using version zonemod2.8.9b) If the data of the weapon in cfgogl1 is not available in cfgogl2, it will be inherited after switching to cfgogl2

To Reproduce Steps to reproduce the behavior: Example 1:

  1. Use !chmatch/!rmatch/!match to switch ZoneMod 2.8.9
  2. Use !chmatch/!rmatch/!match to switch to Pmelite
  3. At this point, the pushshotgun and shotgun_chrome parameters in pmelite are the same as the values in zonemod 2.8.9

Example 2:

  1. In cfgogl1, have the parameter [sm_weapon sniper_scout clipsize 10]
  2. In cfgogl2, there is no parameter setting for [sm_weapon sniper_scout clipsize 10]
  3. After switching from cfgogl1 to cfgogl2, the parameter [sm_weapon sniper_scout clipsize 10] is also included in cfgogl2

2b054decb2db825f06211c03c505314c

Server Operating System (if applicable):

SirPlease commented 4 months ago

I was unable to reproduce this on my own servers (which are almost identical to the github repo), but was able to reproduce it on local servers. I'll do some further testing soon.

cy115 commented 2 months ago

match_vote.zip try this, just two express solve the problem

A1mDev commented 2 months ago

Isn't the plugin unloading? Method OnPluginEnd should work in it and reset all settings.

A1mDev commented 2 months ago

I think not a single plugin is unloaded when changing the config, because in plugin l4d2_weapon_attributes.smx function OnPluginEnd definitely does not work, I checked it.

cy115 commented 2 months ago

I think not a single plugin is unloaded when changing the config, because in plugin l4d2_weapon_attributes.smx function OnPluginEnd definitely does not work, I checked it.

why not try my plugin? what i have done was just let server use "sm_weapon_attributes_reset" command which from attr plugin,before you load another config : ) however, both !rmatch then !match again and !chmatch make the changed parameters work correctly

cy115 commented 2 months ago

however, at least clipsize can reset to default, at least when i test the plugin.

NanakaFathry commented 2 weeks ago

match_vote.zip try this, just two express solve the problem

It seems to have failed on the SM1.12 platform

SirPlease commented 1 week ago

If you're going to troubleshoot non-related issues (or even worse, related issues) refrain from doing it in a different language.

NanakaFathry commented 1 week ago

If you're going to troubleshoot non-related issues (or even worse, related issues) refrain from doing it in a different language.

ni bu hui gu ge fan yi ma wo de hao xiong di a ? wo men yong zhong wen tao lun hen shu fu wei shen me yao shan chu ?

HadwinOFE commented 1 week ago

If you're going to troubleshoot non-related issues (or even worse, related issues) refrain from doing it in a different language.

ni bu hui gu ge fan yi ma wo de hao xiong di a ? wo men yong zhong wen tao lun hen shu fu wei shen me yao shan chu ?

No choice, since English is the most popular language. GitHub is a global platform for learning and communication, and the error rate for machine-translated discussions is quite high. If you saw a bunch of discussions in Spanish on some issues, I believe you wouldn't like it either 没办法,谁让英语是最流行语言呢?github是全球性的学习与交流平台,机翻翻译这些讨论的错翻率更不用说了,如果在别的issue看到一堆西语讨论问题的话相信你也不喜欢看见