SirPlease / L4D2-Competitive-Rework

Just refreshing and optimizing the core files a bit, eh?
GNU General Public License v3.0
243 stars 132 forks source link

More translations and an option added to colors.inc #791

Closed lechuga16 closed 1 month ago

lechuga16 commented 2 months ago

Translations:

specrates_test:

SirPlease commented 2 months ago

I'm curious as to why you'd want to increase the MAX_MESSAGE_SIZE. From testing this will either entirely refuse to print messages when exceed the SayText size and at best give you a few extra characters when you're using color tags.

lechuga16 commented 2 months ago

this solution is old, I just didn't report it before. l4d2_skill_detect prints cut message, between tests it occurred to me to increase the MAX_MESSAGE_SIZE limit and it was solved. Already allowing the limit to be modifiable would solve this type of problem.

SirPlease commented 2 months ago

this solution is old, I just didn't report it before. l4d2_skill_detect prints cut message, between tests it occurred to me to increase the MAX_MESSAGE_SIZE limit and it was solved. Already allowing the limit to be modifiable would solve this type of problem.

I'm saying that once you reach the limit of SayText2 it will refuse to print it entirely, so to me it seems that modifying this will only solve some edge cases that need a few more characters (~4 characters) while it will prevent others to print at all (not even cut). I don't consider this a solution 😅

lechuga16 commented 2 months ago

this solution is old, I just didn't report it before. l4d2_skill_detect prints cut message, between tests it occurred to me to increase the MAX_MESSAGE_SIZE limit and it was solved. Already allowing the limit to be modifiable would solve this type of problem.

I'm saying that once you reach the limit of SayText2 it will refuse to print it entirely, so to me it seems that modifying this will only solve some edge cases that need a few more characters (~4 characters) while it will prevent others to print at all (not even cut). I don't consider this a solution 😅

mmmm

Screenshot_1

lechuga16 commented 2 months ago

In any case, this commit does not deal with this error, it will be put on hold