Skidamek / AutoModpack

Enjoy a seamless modpack installation process and effortless updates with a user-friendly solution that simplifies management, making your gaming experience a breeze.
https://modrinth.com/mod/automodpack
GNU Lesser General Public License v3.0
92 stars 29 forks source link

Errors while downloading modpack #92

Closed dAKirby309 closed 1 year ago

dAKirby309 commented 1 year ago

Firstly is there a way to prevent the system from updating itself? Because it was working great before until it updated itself to the new version (3.0.1) and then things broke.

I'm on Minecraft 1.19.0 Fabric. The Automodpack jar version I had (v2.4.1) on my client and server is no longer recognized as a mod, and this newest 3.0.1 version that it installed or even when I installed it manually makes the mod "seen" in my list of mods on client, but none of its functionality works. No check for update button, no auto-syncing with our server, nothing.

And also no mention of Automodpack doing anything in the server logs.

I don't know why or how it got messed up but this is a setback since I was needing to test other things and instead I had to spend my time trying to figure this out to no avail.

I tried updating and messing with Automodpack on my server and client. No dice.

Inversil commented 1 year ago

yeah this sucks, setting updateCheck to false also doesn't seem to mitigate the automatic update. The new update broke the mod.

Skidamek commented 1 year ago

I am sorry that's my bad, I'm thinking of removing the auto-update system. Based on the stats on modrinth, it seems like it downloads the quilt version of the mod even when you play on fabric, which could be why things aren't working for you. You can try redownloading the correct version of the mod, like fabric 1.19.2, and see if that helps.

Skidamek commented 1 year ago

Also modified previous jars (2.4.1) to prevent auto-updates to 3.x.x. (On modrinth and github, cf doesn't provide that option), so you can use the old version if you want to.

https://modrinth.com/mod/automodpack/version/2.4.1-1.19 https://modrinth.com/mod/automodpack/version/2.4.1-1.18

Inversil commented 1 year ago

thank you!! I was using the old version because it still has support for the cloud hosted modpack zip link. You didn't have to do this - but you did, so thank you so much!

dAKirby309 commented 1 year ago

Also modified previous jars (2.4.1) to prevent auto-updates to 3.x.x. (On modrinth and github, cf doesn't provide that option), so you can use the old version if you want to.

https://modrinth.com/mod/automodpack/version/2.4.1-1.19 https://modrinth.com/mod/automodpack/version/2.4.1-1.18

I really appreciate your quick response to this! However, I'm still getting the problem where it automatically updates to 3.01 by downloading the modified jar that you linked me for 1.19. I deleted the existing AutoModpack jars. And the same error of the game thinking I don't have Automodpack installed. What else am I missing here? image image image

Inversil commented 1 year ago

Hello! just tested it. running into the same thing- it still updates.

RatDonkeyGoat commented 1 year ago

hey everyone i fixed 2.4.1 to not auto update anymore if you would like the file here you go!

https://github.com/Skidamek/AutoModpack/issues/92#issuecomment-1413678240 these files do not work

Old AutoModpack without auto updating.zip this above file will work

Skidamek commented 1 year ago

Hey, thanks @RatDonkeyGoat, i improved that a bit and updated jars again!

https://modrinth.com/mod/automodpack/version/2.4.1-1.19 https://modrinth.com/mod/automodpack/version/2.4.1-1.18

dAKirby309 commented 1 year ago

I don't know what's going on here. Does this updated 2.4.1 jar prevent auto-updates now? Yes. Does it seem to work properly? Not that I can tell.

Firstly, I simply downloaded this 2.4.1 jar into the /mods/ folder on client and server. Secondly, I launched the server and then deleted all of the mods in the client's /mods/ folder and then I re-ran the client and tried to connect. I got an error: image

Secondly, in order to try and fix this, I deleted the existing Automodpack folder in the server and re-ran client and server. Upon simply opening the client Minecraft Launcher and pressing Play, it got a popup ever time saying to update the modpack and it did not actually launch the game and the server logs said this in the screenshot each time. I tried 7 times. image image

Next, I deleted the mods (except for Automodpack.jar) and the Automodpack folder on my client and relaunched the client by pressing Play on the Launcher and the game did launch this time and I tried to connect to the server, and it downloaded the mods. Upon restarting my client and trying to reconnect to the server, I was greeted with yet another error screen image

And I still cannot connect to the server. What is going on here?

Skidamek commented 1 year ago

Thats old automodpack bug from 2.4.1 look #69 This is fixed in v3

But to bypass it you should be able to just delete AutoModpack folder on client restart game, join server, download modpack again and it should work again

dAKirby309 commented 1 year ago

Like I mentioned, I already tried this. But I tried it again now, and the same thing happens.

Deleted Automodpack folder on client: image

Restarted game and attempted to join: image

Skidamek commented 1 year ago

I see, so looks like this isn't automodpack releated bug or that's old 2.4.1 version bug which is already fixed in new 3.0.1 version

Skidamek commented 1 year ago

Better try new version... https://modrinth.com/mod/automodpack/version/uodQ7wS5

dAKirby309 commented 1 year ago

(Sorry for the ghost posts that I deleted. Both times, I accidentally commented too early) Ok so I downloaded your Automodpack 3.0.1.jar on client and server and did the following...

I deleted the existing automodpack folder on client and on server, and I deleted the config for both of them so that all the automodpack files could regenerate. Note: the automodpack config file did not regenerate on my client when launching the game or anything, so I restored the config file from the recycle bin. But doing so makes no difference to the end-result.

Only the automodpack.jar is in /mods/ and it installs fabric api like it should. image image

Then I relaunch Fabric 1.19 client and join the server, and it downloads the mods image

I click on Restart on the client image

Fabric API gets deleted on its own image

I relaunch the game from client again, and nothing happens. The game does not then launch. I've tried going through this multiple times.

And even if I manually put Fabric API.jar into the /mods/ folder, it gets deleted on its own when I try launching the game. No other mods from the server go into the /mods/ folder like they're supposed to.

This is not working.

Skidamek commented 1 year ago

Looks similar to #93 Can you send last two logs from client?

dAKirby309 commented 1 year ago

Client logs:

Skidamek commented 1 year ago

Oh no, you get stuck in the loop

Can you send from server these files? (worldedit.properties, FabricHomes.properties)

[05:41:52] [pool-2-thread-4/INFO]: Downloading worldedit.properties... (attempt 1) [05:41:52] [pool-2-thread-3/INFO]: Downloading FabricHomes.properties... (attempt 1) [05:41:52] [pool-2-thread-4/INFO]: URL: http://192.168.86.137:30037/config/worldedit/worldedit.properties [05:41:52] [pool-2-thread-3/INFO]: URL: http://192.168.86.137:30037/config/FabricHomes.properties [05:41:52] [pool-2-thread-3/WARN]: Checksums do not match, retrying... client: 9376724cc233a3f5f7d5d127e6c3ee8e9b18b4016e1c898adaf73136f5f02482 server: a96d33cbcbc429a458e6d4472c14aa826f9f91e8a0b183e7c945f958c6157dab [05:41:52] [pool-2-thread-4/WARN]: Checksums do not match, retrying... client: cd2e140e591c36a9dcef2e92a7d4864cc497fd9843d09fd0f0d5bb1d3abb699c server: 8d50898fac9cec9d83ea6e7329f7285aa370bf616f8666785a1a225052beb638 [05:41:52] [pool-2-thread-3/INFO]: Downloading FabricHomes.properties... (attempt 2) [05:41:52] [pool-2-thread-4/INFO]: Downloading worldedit.properties... (attempt 2) [05:41:52] [pool-2-thread-3/INFO]: URL: http://192.168.86.137:30037/config/FabricHomes.properties [05:41:52] [pool-2-thread-4/INFO]: URL: http://192.168.86.137:30037/config/worldedit/worldedit.properties [05:41:52] [pool-2-thread-3/WARN]: Checksums do not match, retrying... client: 9376724cc233a3f5f7d5d127e6c3ee8e9b18b4016e1c898adaf73136f5f02482 server: a96d33cbcbc429a458e6d4472c14aa826f9f91e8a0b183e7c945f958c6157dab [05:41:52] [pool-2-thread-4/WARN]: Checksums do not match, retrying... client: cd2e140e591c36a9dcef2e92a7d4864cc497fd9843d09fd0f0d5bb1d3abb699c server: 8d50898fac9cec9d83ea6e7329f7285aa370bf616f8666785a1a225052beb638 [05:41:52] [pool-2-thread-3/INFO]: Downloading FabricHomes.properties... (attempt 3) [05:41:52] [pool-2-thread-4/INFO]: Downloading worldedit.properties... (attempt 3) [05:41:52] [pool-2-thread-3/INFO]: URL: http://192.168.86.137:30037/config/FabricHomes.properties [05:41:52] [pool-2-thread-4/INFO]: URL: http://192.168.86.137:30037/config/worldedit/worldedit.properties [05:41:52] [pool-2-thread-3/WARN]: Checksums do not match, retrying... client: 9376724cc233a3f5f7d5d127e6c3ee8e9b18b4016e1c898adaf73136f5f02482 server: a96d33cbcbc429a458e6d4472c14aa826f9f91e8a0b183e7c945f958c6157dab [05:41:52] [pool-2-thread-4/WARN]: Checksums do not match, retrying... client: cd2e140e591c36a9dcef2e92a7d4864cc497fd9843d09fd0f0d5bb1d3abb699c server: 8d50898fac9cec9d83ea6e7329f7285aa370bf616f8666785a1a225052beb638 [05:41:52] [pool-2-thread-3/INFO]: Downloading FabricHomes.properties... (attempt 4) [05:41:52] [pool-2-thread-3/INFO]: URL: http://192.168.86.137:30037/config/FabricHomes.properties [05:41:52] [pool-2-thread-4/INFO]: Downloading worldedit.properties... (attempt 4) [05:41:52] [pool-2-thread-4/INFO]: URL: http://192.168.86.137:30037/config/worldedit/worldedit.properties [05:41:52] [pool-2-thread-3/WARN]: Checksums do not match, retrying... client: 9376724cc233a3f5f7d5d127e6c3ee8e9b18b4016e1c898adaf73136f5f02482 server: a96d33cbcbc429a458e6d4472c14aa826f9f91e8a0b183e7c945f958c6157dab [05:41:52] [pool-2-thread-4/WARN]: Checksums do not match, retrying... client: cd2e140e591c36a9dcef2e92a7d4864cc497fd9843d09fd0f0d5bb1d3abb699c server: 8d50898fac9cec9d83ea6e7329f7285aa370bf616f8666785a1a225052beb638 [05:41:52] [pool-2-thread-4/INFO]: Downloading worldedit.properties... (attempt 5) [05:41:52] [pool-2-thread-3/INFO]: Downloading FabricHomes.properties... (attempt 5) [05:41:52] [pool-2-thread-4/INFO]: URL: http://192.168.86.137:30037/config/worldedit/worldedit.properties [05:41:52] [pool-2-thread-3/INFO]: URL: http://192.168.86.137:30037/config/FabricHomes.properties [05:41:52] [pool-2-thread-4/WARN]: Checksums do not match, retrying... client: cd2e140e591c36a9dcef2e92a7d4864cc497fd9843d09fd0f0d5bb1d3abb699c server: 8d50898fac9cec9d83ea6e7329f7285aa370bf616f8666785a1a225052beb638 [05:41:52] [pool-2-thread-3/WARN]: Checksums do not match, retrying... client: 9376724cc233a3f5f7d5d127e6c3ee8e9b18b4016e1c898adaf73136f5f02482 server: a96d33cbcbc429a458e6d4472c14aa826f9f91e8a0b183e7c945f958c6157dab [05:41:52] [pool-2-thread-4/ERROR]: Failed to download worldedit.properties after 5 attempts [05:41:52] [pool-2-thread-3/ERROR]: Failed to download FabricHomes.properties after 5 attempts

dAKirby309 commented 1 year ago

Server logs: 2023-02-04-6.log.gz 2023-02-04-7.log.gz latest.log

Skidamek commented 1 year ago

i mean these files worldedit.properties, FabricHomes.properties

Skidamek commented 1 year ago

or remove config from syncedFiles in server automodpack config

dAKirby309 commented 1 year ago

FabricHomes and worldedit properties config files.zip

I pasted the ZIP's content below.

FabricHomes

Sat Feb 04 05:40:48 CST 2023

bossbar=true max-homes=20 stand-still=3 cooldown=5

Worldedit

Don't put comments; they get removed

Sat Feb 04 05:41:32 CST 2023

max-super-pickaxe-size=5 use-inventory-creative-override=false use-inventory-override=false default-max-polyhedron-points=-1 disallowed-blocks=minecraft\:oak_sapling,minecraft\:jungle_sapling,minecraft\:dark_oak_sapling,minecraft\:spruce_sapling,minecraft\:birch_sapling,minecraft\:acacia_sapling,minecraft\:black_bed,minecraft\:blue_bed,minecraft\:brown_bed,minecraft\:cyan_bed,minecraft\:gray_bed,minecraft\:green_bed,minecraft\:light_blue_bed,minecraft\:light_gray_bed,minecraft\:lime_bed,minecraft\:magenta_bed,minecraft\:orange_bed,minecraft\:pink_bed,minecraft\:purple_bed,minecraft\:red_bed,minecraft\:white_bed,minecraft\:yellow_bed,minecraft\:powered_rail,minecraft\:detector_rail,minecraft\:grass,minecraft\:dead_bush,minecraft\:moving_piston,minecraft\:piston_head,minecraft\:sunflower,minecraft\:rose_bush,minecraft\:dandelion,minecraft\:poppy,minecraft\:brown_mushroom,minecraft\:red_mushroom,minecraft\:tnt,minecraft\:torch,minecraft\:fire,minecraft\:redstone_wire,minecraft\:wheat,minecraft\:potatoes,minecraft\:carrots,minecraft\:melon_stem,minecraft\:pumpkin_stem,minecraft\:beetroots,minecraft\:rail,minecraft\:lever,minecraft\:redstone_torch,minecraft\:redstone_wall_torch,minecraft\:repeater,minecraft\:comparator,minecraft\:stone_button,minecraft\:birch_button,minecraft\:acacia_button,minecraft\:dark_oak_button,minecraft\:jungle_button,minecraft\:oak_button,minecraft\:spruce_button,minecraft\:cactus,minecraft\:sugar_cane,minecraft\:bedrock shell-save-type= craftscript-dir=craftscripts register-help=true snapshots-dir= max-calculation-timeout=300 history-size=15 super-pickaxe-drop-items=true max-changed-blocks=-1 default-max-polygon-points=-1 scripting-timeout=3000 calculation-timeout=100 nav-use-glass=true extended-y-limit=false nav-wand-item=minecraft\:compass log-file= butcher-max-radius=-1 max-radius=-1 wand-item=minecraft\:wooden_axe profile=false use-in-creative=false default-vertical-height=256 super-pickaxe-many-drop-items=true max-polyhedron-points=20 server-side-cui=true snapshots-experimental=false max-brush-radius=6 allow-symbolic-links=false default-locale=default trace-unflushed-sessions=false max-polygon-points=20 default-max-changed-blocks=-1 log-commands=false use-inventory=false log-format=[%1$tY-%1$tm-%1$td %1$tH\:%1$tM\:%1$tS %4$s]\: %5$s%6$s%n cheat-mode=false butcher-default-radius=-1 schematic-save-dir=schematics nav-wand-distance=50

Skidamek commented 1 year ago

Actually i was debugging that a bit but i can't figure out why files like that returns wrong checksums... At the moment one thing what fixes it will be just excluding it from modpack

dAKirby309 commented 1 year ago

I have excluded those two .properties files from the automodpack-server.json file, and the same thing happens. Is this not what you meant?

image

Skidamek commented 1 year ago

Have you restarted the server?

dAKirby309 commented 1 year ago

Yes, and I also tried deleting the automodpack folder from client after excluding those files.

Skidamek commented 1 year ago

Can you send client log? maybe some more file have some issues? Or just try removing config from syncedFiles

dAKirby309 commented 1 year ago

Ok so I excluded the entire /config/ folder and then I was able to join the server (though it launched twice for some reason, and both Minecraft windows that opened are taking up like 1/5th of my screen for some reason, which is strange.) But at least I was able to get on. image

I will try to narrow down which config(s) are causing the issue, I suppose. Because apparently something in the /config/ folder was causing this issue of the client not properly working/connect.

I did notice a strange behavior though, and that was all of the mods synced to .minecraft\automodpack\modpack[IP]\mods but none of the mods went into my .minecraft\mods folder... and yet the client launched and loaded up all of the mods and I was able to connect to the server somehow. Are the mods being loaded from the automodpack folder instead of the native /mods/ folder somehow? image image

Skidamek commented 1 year ago

Great. Weird issue with the screen didn't notice that yet. Two instances of the game likely are because automodpack re-launched game but you clicked launch button on launcher again.

I did notice a strange behavior though, and that was all of the mods synced to .minecraft\automodpack\modpack[IP]\mods but none of the mods went into my .minecraft\mods folder... and yet the client launched and loaded up all of the mods and I was able to connect to the server somehow. Are the mods being loaded from the automodpack folder instead of the native /mods/ folder somehow?

Yeah exactly, it re-launches the game with special jvm property for fabric loader e.g. -Dfabric.addMods="pathToModsFolder" and so they are neatly segregated

dAKirby309 commented 1 year ago

Ok so I tried reproducing the issue that I was having before where the client did not open after it downloaded the server's modpack and now it's loading up fine for some reason when it wasn't before.

I re-included the /config/ folder in the syncedFiles so now everything in /config/ syncs to the client (except for worldedit.properties and FabricHomes.properties) and deleted the Automodpack folder from my client like I tried before, but now things are working correctly somehow. Weird.

But now I am confused. Since mods are now instead loaded from the automodpack folder INSTEAD of from the .minecraft\mods folder, are the config files also loaded from the automodpack config folder INSTEAD of .minecraft\config too now? If so, I have some followup questions...

1) Where do I go now to edit configs? .minecraft\config, or automodpack\config? Are configs in .minecraft\config loaded up at all now? 2) How do we now go about installing and using client mods? I don't know where I'm supposed to put them to get them to load. I tried putting my client-side mods in .mincraft\mods and loaded up the game and got an error of many unmet dependencies. So that didn't work, unless I need the dependencies in .minecraft/mods AS WELL AS automodpack\mods to get the client mods to work?

I'm confused about how this 3.0.1 automodpack system works, as it seems very different from how it was in 2.4.1.

Skidamek commented 1 year ago

Ok, so as you noticed the system is very different than previous one.

Where do I go now to edit configs? .minecraft\config, or automodpack\config? Are configs in .minecraft\config loaded up at all now?

I tried making configs in automodpack folder work but that's just almost impossible, any different mod can handle their own configs in many different ways, so client can edit configs in /.minecraft/config/, not in any different automodpack folder at least if this config is marked as editable in modpack on server.

How do we now go about installing and using client mods? I don't know where I'm supposed to put them to get them to load. I tried putting my client-side mods in .mincraft\mods and loaded up the game and got an error of many unmet dependencies. So that didn't work, unless I need the dependencies in .minecraft/mods AS WELL AS automodpack\mods to get the client mods to work?

Simply look at #93 I am close to fix this, so now you should simply place you own mods in normal /.minecraft/mods/ folder without any issues in near future.

dAKirby309 commented 1 year ago

I still don't quite understand. Where do we put the client mods if we want to keep them separate from the server-required mods? I tried putting them in the host-modpack folder as individual jars (along with the modpack-content.json but the game does not load again. I've tried going through this a few times and restarting the server, etc.

Even when I delete the client mods that get put into my client's automodpack\modpacks\[IP address] folder and try launching the game, it does not open after I press Play.

I don't know why this is so complicated when it was so simple and worked effortlessly in the past. And I can't even get the 2.4.1 version to work anymore.

Skidamek commented 1 year ago

I am sorry this should be effortlessly as well but this is broken at the moment, got it working in dev today but need to fix few other things too. Tomorrow should be fix for that.

dAKirby309 commented 1 year ago

Ok, thank you for the effort. I await the progress :)

Skidamek commented 1 year ago

Temporally fixed in 3.0.2, should be ok for time being. I will improve that in future If you have any more questions just ask/reopen issue

dAKirby309 commented 1 year ago

(Ignore my previous, deleted msg, I found a working version) Thanks for updating this! Initial testing shows that the client opens and works with 3.0.2. I'll mess around with it later today to see if it works out :)

dAKirby309 commented 1 year ago

Yeah I don't know. It's still not working. This time I can't even download the modpack from the server.

First attempt and logs, using 3.0.2 connecting my client to the server: It got stuck before hardly anything was synced to my client. image image Server: 2023-02-05-5.log.gz

Client: 2023-02-05-7.log.gz

Second attempt and logs: It jumped up to 73/170 immediately and then stopped and did not progress. image image Server: 2023-02-05-6.log.gz latest.log

Client: latest.log

Skidamek commented 1 year ago

Huh that's interesting, thanks for reporting though

AStrong34 commented 1 year ago

@Skidamek Are you able to revert everything and go back to the last working version (v2.4.1) and test the new update for offline use on your end so we can continue using this cool mod until the update is ready without issues?

Skidamek commented 1 year ago

@Skidamek Are you able to revert everything and go back to the last working version (v2.4.1) and test the new update for offline use on your end so we can continue using this cool mod until the update is ready without issues?

Sorry for that. You can use 2.4.1(.0) but it have even more bugs. Releasing 3.0.3 in few mins should be ok

Skidamek commented 1 year ago

Please try 3.0.3 https://github.com/Skidamek/AutoModpack/releases/tag/v3.0.3

dAKirby309 commented 1 year ago

Hi, I've been trying 3.0.3 and so it does download the mods, but I don't know why it's still not fully working.

All the mods and configs get copied into the automodpack folder but the game doesn't open back up either on its own or when I manually try relaunching the game. It sits there working in the background (as evidenced by the .minecraft\logs folder files keep getting changed on their own), and after several minutes it sends an Uncaught exception in thread "main" error for Fabric Loader. image

Here is a client-side log as it was doing stuff in the background: latest.txt

Additionally, I'm not sure if this is informative or not, but every time after I tried downloading the modpack from the server, it put only these two mods into the .minecraft\mods folder - smoothchunk and hostilevillages. Those two mods are also present in the automodpack\..\mods folder with the rest of the mods. image

I hope this helps.

Skidamek commented 1 year ago

~~Yhmm in logs it looks like you have many instances of minecraft opened in the same time... Could you check task manager and kill every java related to minecraft task and try launching minecraft again?~~

Skidamek commented 1 year ago

this is strange

Skidamek commented 1 year ago

hostilevillages and smoothchunk shoudn't are forge mods, automodpack coudn't recognize that as a mod so copied it into the main minecraft folders

Skidamek commented 1 year ago

try removing hostilevillages and smoothchunk from modpack, that could potentially work...

Skidamek commented 1 year ago

I think i found the issue

Skidamek commented 1 year ago

Okay i got it. Can you download the right versions of HostileVillages and SmoothChunk, swap the 3.0.3 build with this new one (which I hope is fixed) and give it a try? Let's hope it works now.

new-build-unzip-this-file.zip

dAKirby309 commented 1 year ago

Ok, I haven't yet downloaded that new build you worked on, and I'm sorry if my comments don't suggest this, but I really appreciate your quick responses and the effort and care you're putting into this!

That aside, before I download that new build you just sent (thank you, btw), I must tell you that once I got the correct Fabric versions of hostile villages and smoothchunk, automodpack worked great and just like it should!

Skidamek commented 1 year ago

Great! Anyway if you could try this new build if it also works that good, this should even better but i am not too sure haha

dAKirby309 commented 1 year ago

Hmm, well I replaced the other 3.0.3 file with this new build.zip and the mod was auto updated (to 3.0.3) on both client and server. But then when I tried to connect to the server to download the modpack, it said AutoModpack mismatch.

Updated to 3.0.3 image

AutoModpack mismatch (3.0.2?): image

I have another potential concern for my use-case, but I'll send this info to you, above, first.