search

Sllambias / yucca

Apache License 2.0
17 stars 2 forks source link

Allow users to get config object without uneeded params #135

Closed asbjrnmunk closed 8 months ago

Sllambias commented 8 months ago

Just so I understand, does this allow you to get any of the configs with less required params or does this let you get the datamodule without the plan config? Because to me it seems like the latter while the name of the PR points to the first

Sllambias commented 8 months ago

Or is the point that you can get the ckpt config from just a path (rather than from the args) if you import the new function you made?

Sllambias commented 8 months ago

I think I see no issues with this so once the tests pass we can lgtm! :)

asbjrnmunk commented 8 months ago

Just so I understand, does this allow you to get any of the configs with less required params or does this let you get the datamodule without the plan config? Because to me it seems like the latter while the name of the PR points to the first Or is the point that you can get the ckpt config from just a path (rather than from the args) if you import the new function you made?

The purpose is to:

  1. Be able to instantiate a datamodule for prediction only with the arguments needed for prediction
  2. Be able to get a ckpt_config only from a ckpt_path