Sllambias / yucca

Apache License 2.0
17 stars 2 forks source link

General QOL improvements #143

Closed Sllambias closed 8 months ago

Sllambias commented 8 months ago

Todo:

To be fully tested with (along with pytests):

Sllambias commented 8 months ago

@asbjrnmunk and @jakobamb if you've any QOL improvements you would like to see that are simple/medium difficult to implement add here

asbjrnmunk commented 8 months ago

ad measure flops: When should this be run? It is a full forward pass, so it takes some time and would probably be a bit cumbersome to run always.

Otherwise sounds good.

asbjrnmunk commented 8 months ago

@Sllambias for flop counting you can see https://github.com/asbjrnmunk/agave/blob/main/src/count_flops.py :)

Sllambias commented 8 months ago

reviews of course conditioned on passing automatic test and the manual tests i've written above