Sloeber / arduino-eclipse-plugin

A plugin to make programming the arduino in eclipse easy
https://eclipse.baeyens.it/
419 stars 131 forks source link

Understanding the build #132

Closed wimjongman closed 10 years ago

wimjongman commented 10 years ago

@brodykenrick Local builds are taking a long time. When investigating I found references to your repository and your nexus. Is this causing the delays? Why are these references in the main build?

wimjongman commented 10 years ago

https://github.com/jantje/arduino-eclipse-plugin/blame/master/pom.xml#L4

https://github.com/jantje/arduino-eclipse-plugin/blame/master/pom.xml#L17

jantje commented 10 years ago

Brody hasn't been active on github for some time now. I hope nothing bad happened to him.

brodykenrick commented 10 years ago

Hey guys, missed this - sorry. I'll have a look tomorrow.

On Sunday, March 9, 2014, jantje notifications@github.com wrote:

Brody hasn't been active on github for some time now. I hope nothing bad happened to him.

Reply to this email directly or view it on GitHubhttps://github.com/jantje/arduino-eclipse-plugin/issues/132#issuecomment-37116502 .

I am raising money for cancer research by doing an Olympic distance triathlon - Sponsor me here! http://cantooolympictri2014.gofundraise.com.au/page/BrodyTri2013

brodykenrick commented 10 years ago

@wimjongman - What are the delays that you are seeing and are they in the Travis CI builds(if so is it for the pull request or the commit on main)? or in the build when you do it locally on your machine?

The build/continuous integration is documented at: https://github.com/jantje/arduino-eclipse-plugin/blob/master/readme_travis_deploy.md

When investigating I found references to your repository and your nexus. Why are these references in the main build?

My github account is not used in the travis build -- only @jantje's. See https://github.com/jantje/arduino-eclipse-plugin/blob/master/.travis.yml. The secure tokens and CI_GITHUB_REPOUSERNAME=jantje are only pointing tt Jantje's. This is where the code is pulled from (my repo is in the code commented out as I developed it all against my branch before deploying it to jantje's master). Also only jantje's Travix CI account is used.

My nexus repo is in use - as we never set one up for Jantje. See In https://github.com/jantje/arduino-eclipse-plugin/blob/master/readme_travis_deploy.md for the details. That groupid (with my name in it) is used to make the deployment (and I created my groupid against my github account location -- although there is no link to my repo code - it was just a domain I could be sure was unique and related to this project).

Currently the setup uses the Nexus account created by brodykenrick. Later we will likely move to one controlled by jantje for consistency. The Nexus repo (groupId) is hardcoded for the project as com.github.brodykenrick.arduino-eclipse-plugin in the POM.XML. The groupid is hardcoded many places (in all the POM.xml) files as using a varaible produces warnings.

.travis.yml: Has CI_NEXUS_USERNAME, CI_NEXUS_OAUTH2_TOKEN, CI_GPG_PASSPHRASE for the CI setup (all against my Nexus account).

Is this causing the delays? The above hasn't changed. I just looked and it seems that the builds on Travis CI are taking around 15 mins still (about the same as before). So the delays must be local to a build machine - cna you give a few more details and I will replicate.

jantje commented 10 years ago

@wimjongman any input here?

wimjongman commented 10 years ago

I get this in my build as one of the first lines:

[INFO] Computing target platform for MavenProject: com.github.brodykenrick.arduino-eclipse-plugin:it.baeyens.arduino.core.nl1:2.2.0-SNAPSHOT @ C:\Users\jongw\g
t\arduino-eclipse-plugin\it.baeyens.arduino.core.nl1\pom.xml

It takes a minute before it continues. I'm not sure if this is causing it but the build should not reference back to another repo.

brodykenrick commented 10 years ago

Hey @wimjongman,

There is no other github repo referenced - there is only the unique identifier that happens to look like my github name. That line is simply saying it is building THIS project with that name.

When maven is deploying (not simply building) artifacts will get deployed to this unique I'd (which is my nexus account - as stated in the docs). So that should not affect a build and affect a deploy only as you would expect it to talk to Nexus.

Can you review the docs I referenced above and let me know what aspect is still confusing? I can then work on them to clarify more.

I expect the delays at build start are just normal platform discovery/startup - can you make things more verbose and get a few more logs printed to show where the delay is with more detail?

jantje commented 10 years ago

@wimjongman Can we close this issue?

wimjongman commented 10 years ago

Yes.

Met vriendelijke groet,

Wim

On 16 sep. 2014, at 12:52, jantje notifications@github.com wrote:

@wimjongman Can we close this issue?

— Reply to this email directly or view it on GitHub.

jantje commented 10 years ago

txs