Sloeber / arduino-eclipse-plugin

A plugin to make programming the arduino in eclipse easy
https://eclipse.baeyens.it/
418 stars 131 forks source link

V5.0 testing - Fresh install on Windows gives Error: Program "make" not found in PATH #1666

Open ArminJo opened 3 weeks ago

ArminJo commented 3 weeks ago

A fresh Windows install of V5 results in:

10:43:03 **** Clean-only build of configuration Release for project JK-BMSToPylontechCAN_MightyCore ****
make clean 
Cannot run program "make": Launching failed

Error: Program "make" not found in PATH

typing make on the Windows CMD prompt also results in:

Der Befehl "make" ist entweder falsch geschrieben oder
konnte nicht gefunden werden.

so this is consistent 😀 .

On my 4.4.3 Windows installations on the same PC it runs seamlessly with:

10:56:00 **** Clean-only build of configuration Release for project JK-BMSToPylontechCAN_MightyCore ****
"E:\\Elektro\\Sloeber\\arduinoPlugin\\tools\\make\\make" clean 

Therefore I can not test the 5.0 😢

Duplicate of: https://github.com/Sloeber/arduino-eclipse-plugin/issues/1651#issuecomment-2296038497

jantje commented 3 weeks ago

I think it is strange that in your test the clean in a freshly installed V5 uses make (= external make builder) The default builder in V5 is the internal builder and there the clean works Are you testing with a freshly installed V5 with a V5 created project?

jantje commented 3 weeks ago

I just tried here both the internal builder and the external make builder use the same clean method which is internal (read nothing to be seen on the console) and simply removes all the content from the bin/[configname] folder Not sure why the clean on your freshly installed V5 tries to use make to clean.

jantje commented 3 weeks ago

When investigating I found that menu->project->clean does weird things. I usually go right click project clean which works fine. But I still haven't found a way to trigger make clean (which is how V5 is supposed to work)

ArminJo commented 3 weeks ago

OK newly created projects work for me, but old ones are not migrated.

Printing size "raw Result" results in:

Printing size:: test51.size
"E:\Sloeber5\arduinoPlugin\packages\arduino\tools\avr-gcc\7.3.0-atmel3.6.1-arduino7/bin/avr-size" -A "E:\WORKSPACE_SLOEBER5\test51\bin\Release/test51.elf"
E:\WORKSPACE_SLOEBER5\test51\bin\Release/test51.elf  :
section                      size      addr

"AVR Alternative" also works, but "Arduino Way" (under Windows) results in:

Printing size:: test51.size
wsl -- "E:\Sloeber5\arduinoPlugin\packages\arduino\tools\avr-gcc\7.3.0-atmel3.6.1-arduino7/bin/avr-size" -A "E:\WORKSPACE_SLOEBER5\test51\bin\Release/test51.elf" | "E:\Sloeber5\arduinoPlugin\tools\awk\awk" -f size.awk
/bin/bash: E:Sloeber5arduinoPluginpackagesarduinotoolsavr-gcc7.3.0-atmel3.6.1-arduino7/bin/avr-size: No such file or directory
/bin/bash: E:Sloeber5arduinoPlugintoolsawkawk: command not found
jantje commented 3 weeks ago

There is no auto migration. Opening project properties->sloeber apply close may work

ArminJo commented 3 weeks ago

I now always get this error if I want to open ESP32 project properties->sloeber. On new as well as on old ESP32 projects. grafik

After Clicking OK I see: grafik

It gives no error for new AVR projects but for old AVR ones I see the same error and after clicking OK I see: grafik or grafik

So I give up testing Sloeber5 for now, since only new AVR Projects seems to work for me 😞 .

jantje commented 3 weeks ago

Migration of projects is not going to work. If there is no easy way to get it to work I will have to write some conversion code. For now please test with projects created in v5.

I now always get this error if I want to open ESP32 project properties->sloeber. On new as well as on old ESP32 projects.

Can you zip up the V5 created ESP32 project so I can take a look?

ArminJo commented 3 weeks ago

Here is the Zip: testESP32_C3.zip

jantje commented 2 weeks ago

Seems there is a null case on my system after importing the project. Once that one is fixed all worked "as expected" "as expected" in this case means that the build reported the error #error This library does not work with ESP32 core 3.x. Please use ESP 2.0.17 core. You are kindly invited to port and document the code to 3.x, to fix this problem! I also noted other build errors in esp32 related to missing " I'm looking into it

jantje commented 2 weeks ago

Seems the quoting issue does not happen in an empty sketch with the board in the provided zip. It also didn't happen in my testing. Seems I will have to wait until someone reports something.

ArminJo commented 2 weeks ago

I now always get this error if I want to open ESP32 project properties->sloeber. On new as well as on old ESP32 projects.

This seems to be fixed 😀 Thanks!

The error: Error: Program "make" not found in PATH still happens, when opening an old 4.3.3 configuration. Is there any plan to provide a configuration migration scrip or functionality?

jantje commented 2 weeks ago

The error: Error: Program "make" not found in PATH still happens, when opening an old 4.3.3 configuration. Is there any plan to provide a configuration migration scrip or functionality?

I want V5 to work properly before looking at migration. That is because migration is hard and migrating to a moving target is even harder.