SmartRSS / Smart-RSS

RSS extension
MIT License
114 stars 16 forks source link

2.25.0 only partly fetches new items for all my feeds but then "stalls" with spinners for multiple feeds. #222

Closed guigirl42 closed 1 year ago

guigirl42 commented 1 year ago

Hello & thank you very much for your brand-new update [which i confess, i'd not expected, given some of your previous notes here ;-)]. Sadly, it seems not working properly for me [i have verified the same problem in FF-Nightly, Beta, & Release]. This is a new issue; v2.23 never did this [& i never got 2.24].

Both via auto/timed update-checks, & also when i try to manually update, one or two new items appeared but then all further progress stalls, with the "spinner" animated icon just permanently "whirling" for numerous feeds in my list. All these feeds used to work with the previous version, & still work in Feedbro.

I hope it is fixable. Thanks.

zakius commented 1 year ago

Could you try opening about: debugging, This Firefox, finding SmartRSS on the list, clicking Inspect and observing what shows in the console when the progress stalls? Especially red entries. You can redact any addresses that appear there as these most likely won't matter for now

gabri25ele commented 1 year ago

I confirm, I updated manually and the program froze on the fifth feed, without updating anything

stuck

stuck2

even manually updating just one feed, doesn't work! back to 2.23.2 version, all works fine!

zakius commented 1 year ago

thank you, now I known what to look for, unfortunately it may take some time as I never stumbled upon this bug

as a workaround for now you can try disabling auto removal of old entries, that should allow the process to continue

guigirl42 commented 1 year ago

as a workaround for now you can try disabling auto removal of old entries, that should allow the process to continue

Oh wow, thanks! I made that change, manually synched, & immediately received all the "missing" new items -- no stalling now. Woohoo!

Btw, the auto-removal has never worked for me anyway [i just left it enabled more out of hope than usefulness], & so historically i have had to periodically look at each of my many feeds then manually delete the older ones.

gabri25ele commented 1 year ago

as a workaround for now you can try disabling auto removal of old entries, that should allow the process to continue

but in this way do not go to accumulate too many articles? I remember that I had to enable it because the program had become very slow

zakius commented 1 year ago

personally I remove things manually once I'm done with these, but at one point I had around 10k articles and it still worked relatively fine

and that's just a temporary workaround, I'll release the fix next week

Btw, the auto-removal has never worked for me anyway

I'll try getting this fixed for the next release too, but that may require more debugging to get it done

giiutfff commented 1 year ago

I am having similar issue. Only the first fetch works, anything after first feed fails.

as a workaround for now you can try disabling auto removal of old entries, that should allow the process to continue

No effects for me.

btw 2.24 already had some fetch issue (specifically it doesn't stop some of the rotate icons after fetching), but it at least fetches everything.

zakius commented 1 year ago

There shouldn't be any real difference between 2.24 and 2.25 in that matter, but just to make sure could you try providing error logs too?

edit: do you happen to use multiple feeds from the same service? if that's the case I'm pretty sure I know what's wrong and decreasing polling frequency for these feeds should allow loading of others during next ticks, the proper fix will be released early next week

guigirl42 commented 1 year ago

Hi again @zakius . I also have this problem; it is afaik NOT new to 2.25.0, albeit sadly it definitely still occurs in this new version. It's actually one of the main reasons that historically, each time i have tried to make your AO my default, i have to keep returning to Feedbro, for reliability.

Specifically, atm each of the following feeds, common to both AOs, work reliably in Feedbro but in SmartRSS it's either not at all, or hit & miss [ie, fetching some but not all new updates for these feeds]:

ABC Ockham’s Razor https://www.abc.net.au/feeds/2883682/podcast.xml

OMG! Linux » Feed https://www.omglinux.com/feed/

ABC This Week https://www.abc.net.au/radio/programs/this-week/feed/13499150/podcast.xml

ABC What The Duck?! https://www.abc.net.au/radionational/programs/what-the-duck/feed/13709150/podcast.xml

Jay's LearnLinuxTV https://www.youtube.com/feeds/videos.xml?channel_id=UCxQKHvKbmSzGMvUrVtJYnUA

Guardian Oz YT https://www.youtube.com/feeds/videos.xml?channel_id=UCoWKwd06OC0Y0XpvAa8jfdw

ABC News Daily https://www.abc.net.au/radio/programs/abc-news-daily/feed/9443166/podcast.xml

Joe Collins https://www.youtube.com/feeds/videos.xml?channel_id=UCTfabOKD7Yty6sDF4POBVqA

TechHut https://www.youtube.com/feeds/videos.xml?channel_id=UCjSEJkpGbcZhvo0lr-44X_w

I have verified these URLs are identical in both AOs.

guigirl42 commented 1 year ago

After my preceding post, i've been trying to comply with your earlier request for the about:debugging#/runtime/this-firefox info. That does not work in my daily Nightly profile [the one i use all the time, & with which i created this Issue], as [amongst many other locked-down changes in my user.js] i disable dom.serviceWorkers.enable, & so i get this warning Your browser configuration is not compatible with Service Workers. [Learn more](https://firefox-source-docs.mozilla.org/devtools-user/about_colon_debugging/index.html#service-workers-not-compatible). Does correct behaviour of your AO depend on SWs being available?

Next i launched my virgin Nightly profile [ie, all settings remain first-run]. Fwiw, your AO also fails to fetch all the updates for many of my feeds here too, apparently the same as my daily profile. I do not understand any of the results, but i saved this text file https://pastebin.com/7LJZq3zX for you, wrt the console for this profile. I made multiple attempts to fetch new feeds [meaning, the ones Feedbro gets but yours does not (yours does fetch many new items, just not all of them]. I selected "All Feeds" then clicked "Update all" [did not work]. I later selected some of the individual not-updating feeds, right-clicked & picked "Update" [did not work], then tried "Refetch" [weirdly this is a terrible option, coz instead of doing what it says, it actually removes all the older items for each such feed!].

giiutfff commented 1 year ago

There shouldn't be any real difference between 2.24 and 2.25 in that matter, but just to make sure could you try providing error logs too?

Unfortunately I can't get a useful log.

btw the browser complained it needs new permissions, after the update.

do you happen to use multiple feeds from the same service?

Yes!

zakius commented 1 year ago

@guigirl42 ServiceWorkers aren't required in any way unless something changed in Nightly in preparations for Mv3, but that's unlikely. Overall it seems we have 3 different issues reported in this thread, I'll start with releasing bugfixes for ones introduced in 2.24 and 2.25 and then will investigate yours. Though some mismatches may come from different handling of future dates and such, once I'm done with fixes for new ones let's move to a new thread and figure out what exactly is happening

@giiutfff in that case I know what the issue is and the fix will be ready in a day or two, I'm really sorry for all these issues

guigirl42 commented 1 year ago

image

guigirl42 commented 1 year ago

Oh no. This is another bug, a pretty weird one... this new feed has been misinterpreted in SmartRSS.

image

"What’s in the air in East Palestine, Ohio?" is correct, & the actual audio file accompanying it is correct... but all the accompanying descriptive text is wrong -- it actually comes from another new feed today; https://7ampodcast.com.au/episodes/asio-is-worried-youre-helping-foreign-spies

:open_mouth: :woman_shrugging:

zakius commented 1 year ago

Patched version will be released today, due to amount of bugs introduced in 2.24 and 2.25 I'll be closing this thread and asking everyone, who reported here, to verify if their issues got fixed, and if not, to report remaining ones in new, separate issues