search

SmilyOrg / photofield

Experimental fast photo viewer.
MIT License
402 stars 7 forks source link

Left/Right keys don't proceed past photos with different aspect ratios #20

Closed Darthagnon closed 1 year ago

Darthagnon commented 1 year ago

Describe the bug Testing on localhost, I found that I had some trouble cycling through photos with the arrow keys when the aspect ratio changed. Here's the photos I was testing with; I would start at the beginning, press Right Right Right [...] and then I couldn't cycle from the 2nd to last (black and white cartoon) on to the last photo (stars over beach). Cycling left, I had no problems, despite identical changes in aspect ratio.

Expected behavior Should be able to cycle with arrow keys without it randomly stopping? Unknown cause, see above for the sample photos.

Desktop (please complete the following information):

Smartphone (please complete the following information): N/A

Darthagnon commented 1 year ago

Suggestion:

Up/Down arrow keys seem to do nothing at the moment - would it be possible to set them to zoom in/out? or navigation...

SmilyOrg commented 1 year ago

I can reproduce it easily with your files and it definitely looks all kinds of buggy! It might have something to do with the recent refactoring in #17. I'll look into it, thanks!

Up/Down arrow keys seem to do nothing at the moment - would it be possible to set them to zoom in/out? or navigation...

Hmm, not sure how useful it is for them to zoom in/out (how often do you want to zoom into the e.g. center specifically?), but maybe some kind of extra navigation makes sense? Like skipping to the next day or next event or something like that 🤔

SmilyOrg commented 1 year ago

@Darthagnon hey, this should be now fixed in v0.5.1. Let me know if you still see this problem.

Darthagnon commented 1 year ago

Fixed! Thank you so much!

RE: the "zoom" idea, it was more along the lines of, say, down arrow also doing what ESC currently does, and up arrow doing what ENTER (or spacebar preview) does in other software; might be a bit too weird, though.

Darthagnon commented 1 year ago

Is the loading/indexing animation new? I love it!

SmilyOrg commented 1 year ago

Fixed! Thank you so much!

Thanks for reporting!

RE: the "zoom" idea, it was more along the lines of, say, down arrow also doing what ESC currently does, and up arrow doing what ENTER (or spacebar preview) does in other software; might be a bit too weird, though.

Hmm yeah, I'll have to try it out. Not sure what up arrow would do since it's already in "preview" while zoomed in, no?

Is the loading/indexing animation new? I love it!

It's been in there for a version or two, but you might not see it if it loads quickly enough :)