Closed zach-capalbo closed 1 year ago
Hey, thanks a lot for contributing! I've been meaning to add something like this, just haven't gotten around to it yet!
I'll take a look at the code when I get the chance, but it looks good from a first glance.
One interesting synergy might also be with the tagging system I've been trialing in a branch. The reverse geo could be used to create tags like "city:Dublin", "country:Ireland", etc. Would make it neat for search.
Thanks for taking a look!! I'm not sure that I'll have much time in the next few weeks to get back to this, so please feel free to take it over and combine it with other features that you're working on. If I get some time before then, I'll make the changes to address your comments
@zach-capalbo I finally took some time to make the changes above! I still think the rgeo initialization time is a bit of a non-starter to be able to merge this as is, but it should be fine if it's behind a feature flag. In fact, lemme do that...
Photofield is great! But I sometimes forget where I've taken my photos, so I've added some code to extract the GPS coordinates from the EXIF data, and use rgeo to lookup the location. Coordinates and location are stored in the database. Unique locations are displayed on the timeline events next to the date.
I'm submitting this PR in case this is useful or helpful. Feel free to accept it or not if it aligns with the goals of the photofield project. Just some notes about this implementation:
Anyway, hope this is helpful in some way!