search

SmiteshP / nvim-navic

Simple winbar/statusline plugin that shows your current code context
Apache License 2.0
1.35k stars 49 forks source link

nvim-navic not working due to recent commit #130

Closed jackfranklin closed 11 months ago

jackfranklin commented 11 months ago

I did an update to my plugins today and noticed that nvim-navic was no longer showing anything as I navigated through a TypeScript project. I then also confirmed it wasn't working in a Lua project either.

I did some checking of commits and as of https://github.com/SmiteshP/nvim-navic/commit/e6da6f74d89de65258ea7e98e22103ff5de6dcf5, it was working just fine. Will continue to try recent commits to see if I can hunt down the issue.

jackfranklin commented 11 months ago

Don't ask me why as I have no idea, but if I checkout the next commit https://github.com/SmiteshP/nvim-navic/commit/0f2732e695af43b6fc07e5bd0cde66b4a54dfee1, it breaks, even though that commit is only formatting!

ChristianChiarulli commented 11 months ago

Seems to be more than just differences in formatting @jackfranklin

https://github.com/SmiteshP/nvim-navic/blob/e6da6f74d89de65258ea7e98e22103ff5de6dcf5/lua/nvim-navic/init.lua

https://github.com/SmiteshP/nvim-navic/blob/0f2732e695af43b6fc07e5bd0cde66b4a54dfee1/lua/nvim-navic/init.lua

The issue was actually introduced in this commit: https://github.com/SmiteshP/nvim-navic/commit/59429b84faab893628bc0f3646665ce40be11d05

jackfranklin commented 11 months ago

Ah thank you @ChristianChiarulli, I didn't spot that. I have sent #131 which fixes it for me locally.

augustocdias commented 11 months ago

The is_available function is returning false all the time as well.

SmiteshP commented 11 months ago

Apologies guys, I merged a PR without testing it locally first 🙈

leon-richardt commented 11 months ago

Sorry everyone, this one is on me! It's beyond me how I made that change and didn't notice after.