[BUG] Flash Incorrect compression config

Snapchat / KeyDB

A Multithreaded Fork of Redis

https://keydb.dev

BSD 3-Clause "New" or "Revised" License

11.02k stars 564 forks source link

[BUG] Flash Incorrect compression config #754

Open keithchew opened 7 months ago

keithchew commented 7 months ago

In rocksdbfactory.cpp, we have:

    options.compression = rocksdb::kNoCompression;

but it should be:

    options.compression = rocksdb::CompressionType::kNoCompression;

Enabling logging in rocksdb will confirm that the former will not disable compression (ie "compression": "Snappy"), but the latter will (ie "compression": "NoCompression").

alija83 commented 3 weeks ago

What is the setting/config to enable compression in KeyDB for Flash data type storage ? I was not able to get compression activated in keydb with flash. Would the .sst/log files get compressed ?