build: Fix building using system TLS and hiredis

Snapchat / KeyDB

A Multithreaded Fork of Redis

https://keydb.dev

BSD 3-Clause "New" or "Revised" License

11.02k stars 564 forks source link

build: Fix building using system TLS and hiredis #807

Open guillemj opened 3 months ago

guillemj commented 3 months ago

The commit to add support to use the system hiredis entangled the TLS and hiredis system ussage, but while related, the TLS support is not conditional on whether we use the system hiredis.

Detangle them so that we link against the system OpenSSL libraries again.

Fixes: commit 657229a9ac6e7c9d9820bf74061c1e0a4a12f927

JohnSully commented 3 months ago

I'm a bit suspicious of the CI failures will need a deeper dive

{12008:12023:S 26 Mar 2024 19:57:42.694 # Internal error in RDB reading offset 9610080, function at rdb.c:3529 -> Unexpected EOF reading RDB file. Failure loading rdb format from socket, assuming connection error, resuming operation.} 52