Solid-Energy-Systems / NewareNDA

Python module and command line tool for reading and converting Neware nda and ndax battery cycling data files.
BSD 3-Clause "New" or "Revised" License
17 stars 10 forks source link

Fix for files that fail to load #15

Closed d-cogswell closed 2 years ago

d-cogswell commented 2 years ago

Occasionally some bytes beyond the last data record were being processed as new records. A stricter check for identifying valid records seems to have fixed this.

d-cogswell commented 2 years ago

Please help test that these changes did not break anything.

yliu-electra commented 2 years ago

How should this be tested?

On Thu, Aug 4, 2022 at 1:03 PM Dan Cogswell @.***> wrote:

Please help test that these changes did not break anything.

— Reply to this email directly, view it on GitHub https://github.com/Solid-Energy-Systems/NewareNDA/pull/15#issuecomment-1205661367, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZDN4TU4Z2FK3A47B3MBO43VXQHZDANCNFSM55TSN4IQ . You are receiving this because your review was requested.Message ID: @.***>

--

Yuxiang Liu​​ | Senior Data Scientist Email: @.*** Website: www.electravehicles.com Direct Line: +1 (970) 402‑6821 Main Line: +1 (617) 313‑7842 Address: 110 K Street, Suite 330, Boston, MA 02127 http://www.electravehicles.com/ [image: LinkedIn] https://www.linkedin.com/company/electra-vehicles-inc/ [image: Twitter] http://twitter.com/ElectraVehicles https://www.electravehicles.com/eve-ai-adaptive-controls

Yuxiang Liu | Senior Data Scientist Email: @.*** Website: www.electravehicles.com Direct Line: +1 (970) 402-6821 Main Line: +1 (617) 313-7842 Address: 110 K Street, Suite 330, Boston, MA 02127

wmses commented 2 years ago

I test your new NDA reader on all the NDA files for the Electra project, and it seems to be working fine.

d-cogswell commented 2 years ago

How should this be tested?

For now just manually check your plots to make sure nothing changed. I'm working on automated regression testing.

yliu-electra commented 2 years ago

Hi Dan,

I have conducted some testing here. I think the reader is probably fine reading out measurements. But there are definitely differences there. I noticed the step numbers have changed. Please see the attached. Also, as the below showed, the old reader overflowed. The new reader has seemed to correct it. Is this something expected?

Old: 5307663,364,32767,Rest,30.0,4.028,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:02,25.7,,S220502B018 5307664,364,-32768,CC_DChg,0.0,3.8941,-12627.1,0.0,0.0,0.0,0.0,2022-08-07 23:11:03,25.7,,S220502B018 5307665,364,-32768,CC_DChg,1.0,3.8904,-12630.2,0.0,3.5077777,0.0,13.653277,2022-08-07 23:11:03,25.5,,S220502B018 5307666,364,-32768,CC_DChg,2.0,3.8873,-12630.2,0.0,7.0161667,0.0,27.296278,2022-08-07 23:11:04,25.7,,S220502B018

New: 5307663,364,32767,Rest,30.0,4.028,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:02,25.7,,S220502B018 5307664,364,32768,CC_DChg,0.0,3.8941,-12627.1,0.0,0.0,0.0,0.0,2022-08-07 23:11:03,25.7,,S220502B018 5307665,364,32768,CC_DChg,1.0,3.8904,-12630.2,0.0,3.5077777,0.0,13.653277,2022-08-07 23:11:03,25.5,,S220502B018 5307666,364,32768,CC_DChg,2.0,3.8873,-12630.2,0.0,7.0161667,0.0,27.296278,2022-08-07 23:11:04,25.7,,S220502B018

Old: 5307757,364,-32765,Rest,0.0,3.927,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:33,28.0,,S220502B018 5307758,364,-32765,Rest,1.0,3.9347,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:34,27.8,,S220502B018 5307759,364,-32765,Rest,2.0,3.94,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:35,28.0,,S220502B018 5307760,364,-32765,Rest,3.0,3.9437,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:36,28.0,,S220502B018 5307761,364,-32765,Rest,4.0,3.9462,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:37,27.8,,S220502B018 5307762,364,-32765,Rest,5.0,3.9487,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:38,27.6,,S220502B018

New: 5307757,364,32771,Rest,0.0,3.927,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:33,28.0,,S220502B018 5307758,364,32771,Rest,1.0,3.9347,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:34,27.8,,S220502B018 5307759,364,32771,Rest,2.0,3.94,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:35,28.0,,S220502B018 5307760,364,32771,Rest,3.0,3.9437,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:36,28.0,,S220502B018 5307761,364,32771,Rest,4.0,3.9462,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:37,27.8,,S220502B018 5307762,364,32771,Rest,5.0,3.9487,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:38,27.6,,S220502B018

On Fri, Aug 5, 2022 at 1:49 PM Dan Cogswell @.***> wrote:

Merged #15 https://github.com/Solid-Energy-Systems/NewareNDA/pull/15 into development.

— Reply to this email directly, view it on GitHub https://github.com/Solid-Energy-Systems/NewareNDA/pull/15#event-7138376261, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZDN4TWJBT3REIS4UCUAO7LVXVV4BANCNFSM55TSN4IQ . You are receiving this because your review was requested.Message ID: @.***>

--

Yuxiang Liu​​ | Senior Data Scientist Email: @.*** Website: www.electravehicles.com Direct Line: +1 (970) 402‑6821 Main Line: +1 (617) 313‑7842 Address: 110 K Street, Suite 330, Boston, MA 02127 http://www.electravehicles.com/ [image: LinkedIn] https://www.linkedin.com/company/electra-vehicles-inc/ [image: Twitter] http://twitter.com/ElectraVehicles https://www.electravehicles.com/eve-ai-adaptive-controls

Yuxiang Liu | Senior Data Scientist Email: @.*** Website: www.electravehicles.com Direct Line: +1 (970) 402-6821 Main Line: +1 (617) 313-7842 Address: 110 K Street, Suite 330, Boston, MA 02127

c:\Projects\ses\etl\NewareNDA>fc C:\Projects\ses\Datasets\OneDrive_2022-08-09\csv\old_reader C:\Projects\ses\Datasets\OneDrive_2022-08-09\csv\new_reader FC: cannot open C:\PROJECTS\SES\DATASETS\ONEDRIVE_2022-08-09\CSV\OLD_READER - No such file or folder

(Redshift_Serverless) c:\Projects\ses\etl\NewareNDA>fc "C:\Projects\ses\Datasets\OneDrive_2022-08-09\csv\old_reader\S220502B018_SES PROPRIETARY & CONFIDENTIAL.nda.csv" "C:\Projects\ses\Datasets\OneDrive_2022-08-09\csv\new_reader\S220502B018_SES PROPRIETARY & CONFIDENTIAL.nda.csv" Comparing files C:\PROJECTS\SES\DATASETS\ONEDRIVE_2022-08-09\CSV\OLD_READER\S220502B018_SES PROPRIETARY & CONFIDENTIAL.nda.csv and C:\PROJECTS\SES\DATASETS\ONEDRIVE_2022-08-09\CSV\NEW_READER\S220502B018_SES PROPRIETARY & CONFIDENTIAL.NDA.CSV Resync Failed. Files are too different. * C:\PROJECTS\SES\DATASETS\ONEDRIVE_2022-08-09\CSV\OLD_READER\S220502B018_SES PROPRIETARY & CONFIDENTIAL.nda.csv 5307663,364,32767,Rest,30.0,4.028,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:02,25.7,,S220502B018 5307664,364,-32768,CC_DChg,0.0,3.8941,-12627.1,0.0,0.0,0.0,0.0,2022-08-07 23:11:03,25.7,,S220502B018 5307665,364,-32768,CC_DChg,1.0,3.8904,-12630.2,0.0,3.5077777,0.0,13.653277,2022-08-07 23:11:03,25.5,,S220502B018 5307666,364,-32768,CC_DChg,2.0,3.8873,-12630.2,0.0,7.0161667,0.0,27.296278,2022-08-07 23:11:04,25.7,,S220502B018 5307667,364,-32768,CC_DChg,3.0,3.8845,-12630.2,0.0,10.524555,0.0,40.928917,2022-08-07 23:11:05,25.7,,S220502B018 5307668,364,-32768,CC_DChg,4.0,3.882,-12630.2,0.0,14.032945,0.0,54.55236,2022-08-07 23:11:06,25.7,,S220502B018 5307669,364,-32768,CC_DChg,5.0,3.8802,-12630.2,0.0,17.541334,0.0,68.16844,2022-08-07 23:11:07,25.7,,S220502B018 5307670,364,-32768,CC_DChg,6.0,3.8786,-12630.2,0.0,21.049694,0.0,81.7782,2022-08-07 23:11:08,25.9,,S220502B018 5307671,364,-32768,CC_DChg,7.0,3.8767,-12630.2,0.0,24.558083,0.0,95.38211,2022-08-07 23:11:09,25.9,,S220502B018 5307672,364,-32768,CC_DChg,8.0,3.8749,-12630.2,0.0,28.066473,0.0,108.97972,2022-08-07 23:11:10,25.9,,S220502B018 5307673,364,-32768,CC_DChg,9.0,3.8736,-12630.2,0.0,31.574862,0.0,122.5722,2022-08-07 23:11:11,25.9,,S220502B018 5307674,364,-32768,CC_DChg,10.0,3.8724,-12630.2,0.0,35.08328,0.0,136.1595,2022-08-07 23:11:12,25.9,,S220502B018 5307675,364,-32768,CC_DChg,11.0,3.8709,-12630.2,0.0,38.591667,0.0,149.74242,2022-08-07 23:11:13,25.9,,S220502B018 5307676,364,-32768,CC_DChg,12.0,3.8699,-12630.2,0.0,42.100082,0.0,163.32097,2022-08-07 23:11:14,25.9,,S220502B018 5307677,364,-32768,CC_DChg,13.0,3.8687,-12630.2,0.0,45.60847,0.0,176.89519,2022-08-07 23:11:15,25.9,,S220502B018 5307678,364,-32768,CC_DChg,14.0,3.8671,-12630.2,0.0,49.11689,0.0,190.46417,2022-08-07 23:11:16,26.1,,S220502B018 5307679,364,-32768,CC_DChg,15.0,3.8659,-12630.2,0.0,52.62528,0.0,204.02931,2022-08-07 23:11:17,26.1,,S220502B018 5307680,364,-32768,CC_DChg,16.0,3.865,-12630.2,0.0,56.133694,0.0,217.59058,2022-08-07 23:11:18,26.0,,S220502B018 5307681,364,-32768,CC_DChg,17.0,3.8637,-12630.2,0.0,59.642082,0.0,231.14798,2022-08-07 23:11:19,25.9,,S220502B018 5307682,364,-32768,CC_DChg,18.0,3.8628,-12630.2,0.0,63.1505,0.0,244.70169,2022-08-07 23:11:20,26.1,,S220502B018 5307683,364,-32768,CC_DChg,19.0,3.8619,-12630.2,0.0,66.65892,0.0,258.252,2022-08-07 23:11:21,26.1,,S220502B018 5307684,364,-32768,CC_DChg,20.0,3.8609,-12630.2,0.0,70.167305,0.0,271.79865,2022-08-07 23:11:22,26.1,,S220502B018 5307685,364,-32768,CC_DChg,21.0,3.8594,-12630.2,0.0,73.67572,0.0,285.34116,2022-08-07 23:11:23,26.1,,S220502B018 5307686,364,-32768,CC_DChg,22.0,3.8585,-12630.2,0.0,77.18411,0.0,298.88025,2022-08-07 23:11:24,26.3,,S220502B018 5307687,364,-32768,CC_DChg,23.0,3.8575,-12630.2,0.0,80.69253,0.0,312.41556,2022-08-07 23:11:25,26.3,,S220502B018 5307688,364,-32768,CC_DChg,24.0,3.8566,-12630.2,0.0,84.20092,0.0,325.9478,2022-08-07 23:11:26,26.2,,S220502B018 5307689,364,-32768,CC_DChg,25.0,3.856,-12630.2,0.0,87.709335,0.0,339.47717,2022-08-07 23:11:27,26.2,,S220502B018 5307690,364,-32768,CC_DChg,26.0,3.8547,-12630.2,0.0,91.21772,0.0,353.00308,2022-08-07 23:11:28,26.0,,S220502B018 5307691,364,-32768,CC_DChg,27.0,3.8541,-12630.2,0.0,94.726135,0.0,366.52585,2022-08-07 23:11:29,26.2,,S220502B018 5307692,364,-32768,CC_DChg,28.0,3.8532,-12630.2,0.0,98.23453,0.0,380.04572,2022-08-07 23:11:30,26.2,,S220502B018 5307693,364,-32768,CC_DChg,29.0,3.8519,-12630.2,0.0,101.74294,0.0,393.56207,2022-08-07 23:11:31,26.3,,S220502B018 5307694,364,-32768,CC_DChg,30.0,3.851,-12630.2,0.0,105.251335,0.0,407.07455,2022-08-07 23:11:32,26.3,,S220502B018 5307695,364,-32767,Rest,0.0,3.98,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:33,26.3,,S220502B018 5307696,364,-32767,Rest,1.0,3.9853,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:33,26.3,,S220502B018 5307697,364,-32767,Rest,2.0,3.9884,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:34,26.3,,S220502B018 5307698,364,-32767,Rest,3.0,3.9905,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:35,26.3,,S220502B018 5307699,364,-32767,Rest,4.0,3.9921,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:36,26.1,,S220502B018 5307700,364,-32767,Rest,5.0,3.993,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:37,26.3,,S220502B018 5307701,364,-32767,Rest,6.0,3.9942,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:38,26.0,,S220502B018 5307702,364,-32767,Rest,7.0,3.9955,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:39,26.0,,S220502B018 5307703,364,-32767,Rest,8.0,3.9961,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:40,26.0,,S220502B018 5307704,364,-32767,Rest,9.0,3.9967,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:41,26.2,,S220502B018 5307705,364,-32767,Rest,10.0,3.9973,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:42,26.2,,S220502B018 5307706,364,-32767,Rest,11.0,3.998,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:43,26.2,,S220502B018 5307707,364,-32767,Rest,12.0,3.9986,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:44,26.0,,S220502B018 5307708,364,-32767,Rest,13.0,3.9992,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:45,26.2,,S220502B018 5307709,364,-32767,Rest,14.0,3.9995,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:46,26.0,,S220502B018 5307710,364,-32767,Rest,15.0,3.9998,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:47,26.0,,S220502B018 5307711,364,-32767,Rest,16.0,4.0001,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:48,26.0,,S220502B018 5307712,364,-32767,Rest,17.0,4.0008,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:49,25.9,,S220502B018 5307713,364,-32767,Rest,18.0,4.0011,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:50,26.0,,S220502B018 5307714,364,-32767,Rest,19.0,4.0014,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:51,26.0,,S220502B018 5307715,364,-32767,Rest,20.0,4.0017,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:52,25.9,,S220502B018 5307716,364,-32767,Rest,21.0,4.0017,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:53,25.9,,S220502B018 5307717,364,-32767,Rest,22.0,4.002,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:54,25.9,,S220502B018 5307718,364,-32767,Rest,23.0,4.0023,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:55,25.9,,S220502B018 5307719,364,-32767,Rest,24.0,4.0029,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:56,25.7,,S220502B018 5307720,364,-32767,Rest,25.0,4.0029,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:57,25.9,,S220502B018 5307721,364,-32767,Rest,26.0,4.0032,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:58,25.9,,S220502B018 5307722,364,-32767,Rest,27.0,4.0035,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:59,25.9,,S220502B018 5307723,364,-32767,Rest,28.0,4.0039,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:00,25.9,,S220502B018 5307724,364,-32767,Rest,29.0,4.0039,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:01,26.0,,S220502B018 5307725,364,-32767,Rest,30.0,4.0039,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:02,25.9,,S220502B018 5307726,364,-32766,CC_DChg,0.0,3.7819,-21044.1,0.0,0.0,0.0,0.0,2022-08-07 23:12:03,25.9,,S220502B018 5307727,364,-32766,CC_DChg,1.0,3.7744,-21047.2,0.0,5.8461666,0.0,22.083471,2022-08-07 23:12:04,25.9,,S220502B018 5307728,364,-32766,CC_DChg,2.0,3.7689,-21047.2,0.0,11.692611,0.0,44.131363,2022-08-07 23:12:05,25.9,,S220502B018 5307729,364,-32766,CC_DChg,3.0,3.7645,-21047.2,0.0,17.539055,0.0,66.15183,2022-08-07 23:12:06,25.9,,S220502B018 5307730,364,-32766,CC_DChg,4.0,3.7611,-21047.2,0.0,23.385529,0.0,88.14931,2022-08-07 23:12:07,25.9,,S220502B018 5307731,364,-32766,CC_DChg,5.0,3.758,-21047.2,0.0,29.231972,0.0,110.1285,2022-08-07 23:12:08,26.3,,S220502B018 5307732,364,-32766,CC_DChg,6.0,3.7549,-21047.2,0.0,35.078415,0.0,132.0887,2022-08-07 23:12:09,26.3,,S220502B018 5307733,364,-32766,CC_DChg,7.0,3.7524,-21047.2,0.0,40.924835,0.0,154.03291,2022-08-07 23:12:10,26.5,,S220502B018 5307734,364,-32766,CC_DChg,8.0,3.75,-21047.2,0.0,46.77128,0.0,175.96289,2022-08-07 23:12:11,26.7,,S220502B018 5307735,364,-32766,CC_DChg,9.0,3.7475,-21047.2,0.0,52.617695,0.0,197.8773,2022-08-07 23:12:12,26.7,,S220502B018 5307736,364,-32766,CC_DChg,10.0,3.7453,-21047.2,0.0,58.464138,0.0,219.77881,2022-08-07 23:12:13,26.7,,S220502B018 5307737,364,-32766,CC_DChg,11.0,3.7431,-21047.2,0.0,64.310585,0.0,241.66827,2022-08-07 23:12:14,26.9,,S220502B018 5307738,364,-32766,CC_DChg,12.0,3.7406,-21047.2,0.0,70.15706,0.0,263.5447,2022-08-07 23:12:15,27.1,,S220502B018 5307739,364,-32766,CC_DChg,13.0,3.7388,-21047.2,0.0,76.003525,0.0,285.40878,2022-08-07 23:12:16,26.9,,S220502B018 5307740,364,-32766,CC_DChg,14.0,3.7369,-21047.2,0.0,81.85,0.0,307.26157,2022-08-07 23:12:17,27.1,,S220502B018 5307741,364,-32766,CC_DChg,15.0,3.7351,-21047.2,0.0,87.69647,0.0,329.10358,2022-08-07 23:12:18,27.2,,S220502B018 5307742,364,-32766,CC_DChg,16.0,3.7329,-21047.2,0.0,93.542946,0.0,350.9335,2022-08-07 23:12:19,27.2,,S220502B018 5307743,364,-32766,CC_DChg,17.0,3.731,-21047.2,0.0,99.38942,0.0,372.75204,2022-08-07 23:12:20,27.2,,S220502B018 5307744,364,-32766,CC_DChg,18.0,3.7295,-21047.2,0.0,105.235886,0.0,394.56042,2022-08-07 23:12:21,27.4,,S220502B018 5307745,364,-32766,CC_DChg,19.0,3.7279,-21047.2,0.0,111.08236,0.0,416.35922,2022-08-07 23:12:22,27.4,,S220502B018 5307746,364,-32766,CC_DChg,20.0,3.7258,-21047.2,0.0,116.92883,0.0,438.14783,2022-08-07 23:12:23,27.4,,S220502B018 5307747,364,-32766,CC_DChg,21.0,3.7242,-21047.2,0.0,122.77531,0.0,459.92505,2022-08-07 23:12:24,27.6,,S220502B018 5307748,364,-32766,CC_DChg,22.0,3.7227,-21047.2,0.0,128.62178,0.0,481.69318,2022-08-07 23:12:25,27.6,,S220502B018 5307749,364,-32766,CC_DChg,23.0,3.7211,-21047.2,0.0,134.46822,0.0,503.45132,2022-08-07 23:12:26,27.6,,S220502B018 5307750,364,-32766,CC_DChg,24.0,3.7193,-21047.2,0.0,140.3147,0.0,525.201,2022-08-07 23:12:27,27.8,,S220502B018 5307751,364,-32766,CC_DChg,25.0,3.7174,-21047.2,0.0,146.16116,0.0,546.9408,2022-08-07 23:12:28,27.8,,S220502B018 5307752,364,-32766,CC_DChg,26.0,3.7162,-21047.2,0.0,152.00764,0.0,568.6706,2022-08-07 23:12:29,27.8,,S220502B018 5307753,364,-32766,CC_DChg,27.0,3.7146,-21047.2,0.0,157.85411,0.0,590.3912,2022-08-07 23:12:30,27.8,,S220502B018 5307754,364,-32766,CC_DChg,28.0,3.7131,-21047.2,0.0,163.70058,0.0,612.10333,2022-08-07 23:12:31,27.8,,S220502B018 5307755,364,-32766,CC_DChg,29.0,3.7115,-21047.2,0.0,169.54706,0.0,633.80695,2022-08-07 23:12:32,27.8,,S220502B018 5307756,364,-32766,CC_DChg,30.0,3.71,-21047.2,0.0,175.39352,0.0,655.5017,2022-08-07 23:12:33,28.1,,S220502B018 5307757,364,-32765,Rest,0.0,3.927,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:33,28.0,,S220502B018 5307758,364,-32765,Rest,1.0,3.9347,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:34,27.8,,S220502B018 5307759,364,-32765,Rest,2.0,3.94,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:35,28.0,,S220502B018 5307760,364,-32765,Rest,3.0,3.9437,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:36,28.0,,S220502B018 5307761,364,-32765,Rest,4.0,3.9462,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:37,27.8,,S220502B018 5307762,364,-32765,Rest,5.0,3.9487,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:38,27.6,,S220502B018 * C:\PROJECTS\SES\DATASETS\ONEDRIVE_2022-08-09\CSV\NEW_READER\S220502B018_SES PROPRIETARY & CONFIDENTIAL.NDA.CSV 5307663,364,32767,Rest,30.0,4.028,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:02,25.7,,S220502B018 5307664,364,32768,CC_DChg,0.0,3.8941,-12627.1,0.0,0.0,0.0,0.0,2022-08-07 23:11:03,25.7,,S220502B018 5307665,364,32768,CC_DChg,1.0,3.8904,-12630.2,0.0,3.5077777,0.0,13.653277,2022-08-07 23:11:03,25.5,,S220502B018 5307666,364,32768,CC_DChg,2.0,3.8873,-12630.2,0.0,7.0161667,0.0,27.296278,2022-08-07 23:11:04,25.7,,S220502B018 5307667,364,32768,CC_DChg,3.0,3.8845,-12630.2,0.0,10.524555,0.0,40.928917,2022-08-07 23:11:05,25.7,,S220502B018 5307668,364,32768,CC_DChg,4.0,3.882,-12630.2,0.0,14.032945,0.0,54.55236,2022-08-07 23:11:06,25.7,,S220502B018 5307669,364,32768,CC_DChg,5.0,3.8802,-12630.2,0.0,17.541334,0.0,68.16844,2022-08-07 23:11:07,25.7,,S220502B018 5307670,364,32768,CC_DChg,6.0,3.8786,-12630.2,0.0,21.049694,0.0,81.7782,2022-08-07 23:11:08,25.9,,S220502B018 5307671,364,32768,CC_DChg,7.0,3.8767,-12630.2,0.0,24.558083,0.0,95.38211,2022-08-07 23:11:09,25.9,,S220502B018 5307672,364,32768,CC_DChg,8.0,3.8749,-12630.2,0.0,28.066473,0.0,108.97972,2022-08-07 23:11:10,25.9,,S220502B018 5307673,364,32768,CC_DChg,9.0,3.8736,-12630.2,0.0,31.574862,0.0,122.5722,2022-08-07 23:11:11,25.9,,S220502B018 5307674,364,32768,CC_DChg,10.0,3.8724,-12630.2,0.0,35.08328,0.0,136.1595,2022-08-07 23:11:12,25.9,,S220502B018 5307675,364,32768,CC_DChg,11.0,3.8709,-12630.2,0.0,38.591667,0.0,149.74242,2022-08-07 23:11:13,25.9,,S220502B018 5307676,364,32768,CC_DChg,12.0,3.8699,-12630.2,0.0,42.100082,0.0,163.32097,2022-08-07 23:11:14,25.9,,S220502B018 5307677,364,32768,CC_DChg,13.0,3.8687,-12630.2,0.0,45.60847,0.0,176.89519,2022-08-07 23:11:15,25.9,,S220502B018 5307678,364,32768,CC_DChg,14.0,3.8671,-12630.2,0.0,49.11689,0.0,190.46417,2022-08-07 23:11:16,26.1,,S220502B018 5307679,364,32768,CC_DChg,15.0,3.8659,-12630.2,0.0,52.62528,0.0,204.02931,2022-08-07 23:11:17,26.1,,S220502B018 5307680,364,32768,CC_DChg,16.0,3.865,-12630.2,0.0,56.133694,0.0,217.59058,2022-08-07 23:11:18,26.0,,S220502B018 5307681,364,32768,CC_DChg,17.0,3.8637,-12630.2,0.0,59.642082,0.0,231.14798,2022-08-07 23:11:19,25.9,,S220502B018 5307682,364,32768,CC_DChg,18.0,3.8628,-12630.2,0.0,63.1505,0.0,244.70169,2022-08-07 23:11:20,26.1,,S220502B018 5307683,364,32768,CC_DChg,19.0,3.8619,-12630.2,0.0,66.65892,0.0,258.252,2022-08-07 23:11:21,26.1,,S220502B018 5307684,364,32768,CC_DChg,20.0,3.8609,-12630.2,0.0,70.167305,0.0,271.79865,2022-08-07 23:11:22,26.1,,S220502B018 5307685,364,32768,CC_DChg,21.0,3.8594,-12630.2,0.0,73.67572,0.0,285.34116,2022-08-07 23:11:23,26.1,,S220502B018 5307686,364,32768,CC_DChg,22.0,3.8585,-12630.2,0.0,77.18411,0.0,298.88025,2022-08-07 23:11:24,26.3,,S220502B018 5307687,364,32768,CC_DChg,23.0,3.8575,-12630.2,0.0,80.69253,0.0,312.41556,2022-08-07 23:11:25,26.3,,S220502B018 5307688,364,32768,CC_DChg,24.0,3.8566,-12630.2,0.0,84.20092,0.0,325.9478,2022-08-07 23:11:26,26.2,,S220502B018 5307689,364,32768,CC_DChg,25.0,3.856,-12630.2,0.0,87.709335,0.0,339.47717,2022-08-07 23:11:27,26.2,,S220502B018 5307690,364,32768,CC_DChg,26.0,3.8547,-12630.2,0.0,91.21772,0.0,353.00308,2022-08-07 23:11:28,26.0,,S220502B018 5307691,364,32768,CC_DChg,27.0,3.8541,-12630.2,0.0,94.726135,0.0,366.52585,2022-08-07 23:11:29,26.2,,S220502B018 5307692,364,32768,CC_DChg,28.0,3.8532,-12630.2,0.0,98.23453,0.0,380.04572,2022-08-07 23:11:30,26.2,,S220502B018 5307693,364,32768,CC_DChg,29.0,3.8519,-12630.2,0.0,101.74294,0.0,393.56207,2022-08-07 23:11:31,26.3,,S220502B018 5307694,364,32768,CC_DChg,30.0,3.851,-12630.2,0.0,105.251335,0.0,407.07455,2022-08-07 23:11:32,26.3,,S220502B018 5307695,364,32769,Rest,0.0,3.98,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:33,26.3,,S220502B018 5307696,364,32769,Rest,1.0,3.9853,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:33,26.3,,S220502B018 5307697,364,32769,Rest,2.0,3.9884,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:34,26.3,,S220502B018 5307698,364,32769,Rest,3.0,3.9905,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:35,26.3,,S220502B018 5307699,364,32769,Rest,4.0,3.9921,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:36,26.1,,S220502B018 5307700,364,32769,Rest,5.0,3.993,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:37,26.3,,S220502B018 5307701,364,32769,Rest,6.0,3.9942,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:38,26.0,,S220502B018 5307702,364,32769,Rest,7.0,3.9955,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:39,26.0,,S220502B018 5307703,364,32769,Rest,8.0,3.9961,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:40,26.0,,S220502B018 5307704,364,32769,Rest,9.0,3.9967,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:41,26.2,,S220502B018 5307705,364,32769,Rest,10.0,3.9973,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:42,26.2,,S220502B018 5307706,364,32769,Rest,11.0,3.998,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:43,26.2,,S220502B018 5307707,364,32769,Rest,12.0,3.9986,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:44,26.0,,S220502B018 5307708,364,32769,Rest,13.0,3.9992,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:45,26.2,,S220502B018 5307709,364,32769,Rest,14.0,3.9995,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:46,26.0,,S220502B018 5307710,364,32769,Rest,15.0,3.9998,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:47,26.0,,S220502B018 5307711,364,32769,Rest,16.0,4.0001,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:48,26.0,,S220502B018 5307712,364,32769,Rest,17.0,4.0008,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:49,25.9,,S220502B018 5307713,364,32769,Rest,18.0,4.0011,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:50,26.0,,S220502B018 5307714,364,32769,Rest,19.0,4.0014,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:51,26.0,,S220502B018 5307715,364,32769,Rest,20.0,4.0017,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:52,25.9,,S220502B018 5307716,364,32769,Rest,21.0,4.0017,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:53,25.9,,S220502B018 5307717,364,32769,Rest,22.0,4.002,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:54,25.9,,S220502B018 5307718,364,32769,Rest,23.0,4.0023,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:55,25.9,,S220502B018 5307719,364,32769,Rest,24.0,4.0029,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:56,25.7,,S220502B018 5307720,364,32769,Rest,25.0,4.0029,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:57,25.9,,S220502B018 5307721,364,32769,Rest,26.0,4.0032,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:58,25.9,,S220502B018 5307722,364,32769,Rest,27.0,4.0035,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:11:59,25.9,,S220502B018 5307723,364,32769,Rest,28.0,4.0039,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:00,25.9,,S220502B018 5307724,364,32769,Rest,29.0,4.0039,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:01,26.0,,S220502B018 5307725,364,32769,Rest,30.0,4.0039,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:02,25.9,,S220502B018 5307726,364,32770,CC_DChg,0.0,3.7819,-21044.1,0.0,0.0,0.0,0.0,2022-08-07 23:12:03,25.9,,S220502B018 5307727,364,32770,CC_DChg,1.0,3.7744,-21047.2,0.0,5.8461666,0.0,22.083471,2022-08-07 23:12:04,25.9,,S220502B018 5307728,364,32770,CC_DChg,2.0,3.7689,-21047.2,0.0,11.692611,0.0,44.131363,2022-08-07 23:12:05,25.9,,S220502B018 5307729,364,32770,CC_DChg,3.0,3.7645,-21047.2,0.0,17.539055,0.0,66.15183,2022-08-07 23:12:06,25.9,,S220502B018 5307730,364,32770,CC_DChg,4.0,3.7611,-21047.2,0.0,23.385529,0.0,88.14931,2022-08-07 23:12:07,25.9,,S220502B018 5307731,364,32770,CC_DChg,5.0,3.758,-21047.2,0.0,29.231972,0.0,110.1285,2022-08-07 23:12:08,26.3,,S220502B018 5307732,364,32770,CC_DChg,6.0,3.7549,-21047.2,0.0,35.078415,0.0,132.0887,2022-08-07 23:12:09,26.3,,S220502B018 5307733,364,32770,CC_DChg,7.0,3.7524,-21047.2,0.0,40.924835,0.0,154.03291,2022-08-07 23:12:10,26.5,,S220502B018 5307734,364,32770,CC_DChg,8.0,3.75,-21047.2,0.0,46.77128,0.0,175.96289,2022-08-07 23:12:11,26.7,,S220502B018 5307735,364,32770,CC_DChg,9.0,3.7475,-21047.2,0.0,52.617695,0.0,197.8773,2022-08-07 23:12:12,26.7,,S220502B018 5307736,364,32770,CC_DChg,10.0,3.7453,-21047.2,0.0,58.464138,0.0,219.77881,2022-08-07 23:12:13,26.7,,S220502B018 5307737,364,32770,CC_DChg,11.0,3.7431,-21047.2,0.0,64.310585,0.0,241.66827,2022-08-07 23:12:14,26.9,,S220502B018 5307738,364,32770,CC_DChg,12.0,3.7406,-21047.2,0.0,70.15706,0.0,263.5447,2022-08-07 23:12:15,27.1,,S220502B018 5307739,364,32770,CC_DChg,13.0,3.7388,-21047.2,0.0,76.003525,0.0,285.40878,2022-08-07 23:12:16,26.9,,S220502B018 5307740,364,32770,CC_DChg,14.0,3.7369,-21047.2,0.0,81.85,0.0,307.26157,2022-08-07 23:12:17,27.1,,S220502B018 5307741,364,32770,CC_DChg,15.0,3.7351,-21047.2,0.0,87.69647,0.0,329.10358,2022-08-07 23:12:18,27.2,,S220502B018 5307742,364,32770,CC_DChg,16.0,3.7329,-21047.2,0.0,93.542946,0.0,350.9335,2022-08-07 23:12:19,27.2,,S220502B018 5307743,364,32770,CC_DChg,17.0,3.731,-21047.2,0.0,99.38942,0.0,372.75204,2022-08-07 23:12:20,27.2,,S220502B018 5307744,364,32770,CC_DChg,18.0,3.7295,-21047.2,0.0,105.235886,0.0,394.56042,2022-08-07 23:12:21,27.4,,S220502B018 5307745,364,32770,CC_DChg,19.0,3.7279,-21047.2,0.0,111.08236,0.0,416.35922,2022-08-07 23:12:22,27.4,,S220502B018 5307746,364,32770,CC_DChg,20.0,3.7258,-21047.2,0.0,116.92883,0.0,438.14783,2022-08-07 23:12:23,27.4,,S220502B018 5307747,364,32770,CC_DChg,21.0,3.7242,-21047.2,0.0,122.77531,0.0,459.92505,2022-08-07 23:12:24,27.6,,S220502B018 5307748,364,32770,CC_DChg,22.0,3.7227,-21047.2,0.0,128.62178,0.0,481.69318,2022-08-07 23:12:25,27.6,,S220502B018 5307749,364,32770,CC_DChg,23.0,3.7211,-21047.2,0.0,134.46822,0.0,503.45132,2022-08-07 23:12:26,27.6,,S220502B018 5307750,364,32770,CC_DChg,24.0,3.7193,-21047.2,0.0,140.3147,0.0,525.201,2022-08-07 23:12:27,27.8,,S220502B018 5307751,364,32770,CC_DChg,25.0,3.7174,-21047.2,0.0,146.16116,0.0,546.9408,2022-08-07 23:12:28,27.8,,S220502B018 5307752,364,32770,CC_DChg,26.0,3.7162,-21047.2,0.0,152.00764,0.0,568.6706,2022-08-07 23:12:29,27.8,,S220502B018 5307753,364,32770,CC_DChg,27.0,3.7146,-21047.2,0.0,157.85411,0.0,590.3912,2022-08-07 23:12:30,27.8,,S220502B018 5307754,364,32770,CC_DChg,28.0,3.7131,-21047.2,0.0,163.70058,0.0,612.10333,2022-08-07 23:12:31,27.8,,S220502B018 5307755,364,32770,CC_DChg,29.0,3.7115,-21047.2,0.0,169.54706,0.0,633.80695,2022-08-07 23:12:32,27.8,,S220502B018 5307756,364,32770,CC_DChg,30.0,3.71,-21047.2,0.0,175.39352,0.0,655.5017,2022-08-07 23:12:33,28.1,,S220502B018 5307757,364,32771,Rest,0.0,3.927,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:33,28.0,,S220502B018 5307758,364,32771,Rest,1.0,3.9347,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:34,27.8,,S220502B018 5307759,364,32771,Rest,2.0,3.94,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:35,28.0,,S220502B018 5307760,364,32771,Rest,3.0,3.9437,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:36,28.0,,S220502B018 5307761,364,32771,Rest,4.0,3.9462,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:37,27.8,,S220502B018 5307762,364,32771,Rest,5.0,3.9487,0.0,0.0,0.0,0.0,0.0,2022-08-07 23:12:38,27.6,,S220502B018


d-cogswell commented 2 years ago

Yes, the Step field is now stored as int32, which is why the number changed. See 239575f. The large number of steps in this test could not be stored with 16 bits. Only Step numbers up to 32,767 are correct with the old code.