Solid-Energy-Systems / NewareNDA

Python module and command line tool for reading and converting Neware nda and ndax battery cycling data files.
BSD 3-Clause "New" or "Revised" License
17 stars 10 forks source link

Added support for selecting how Cycle Count is incremented from .nda files #43

Closed AdamOpps closed 11 months ago

AdamOpps commented 11 months ago

Created option for 'cycle_mode' when reading .nda files. Default is Charge mode, so existing functionality should stay the same. Options for a Discharge mode, where the cycle number is incremented on a discharge following a charge step, as well as an Automatic mode that will look for the first non-rest step and use that as the cycle mode.

These are edits that I made for my own analysis work, but I believe others may find them to be useful. People cycling anode half cells sometimes use a discharge-first perspective.

The cycle_mode argument might be better utilized as a keyword arg. Further, the hardware setting for cycle increment is saved in the nda file and possibly could be extracted from the binary directly.