Solid-Energy-Systems / NewareNDA

Python module and command line tool for reading and converting Neware nda and ndax battery cycling data files.
BSD 3-Clause "New" or "Revised" License
15 stars 8 forks source link

Add option for skipping instrument rescaling when not available #49

Closed ml-evs closed 6 months ago

ml-evs commented 6 months ago

As described in #47.

This PR adds an option error_on_missing to read_nda (and read) that allows the parser to continue even when instrument scaling is not possible due to to a missing multiplier. The current behaviour is preserved by the default value of error_on_missing = True.

This allows the package to be used more easily downstream without needing to wait for new multipliers to be added and released.

Before merging this, there is no test data available to contributors (presumably you have some somewhere!) so consider this PR as untested! (It works for me with my own data, of course...) -- see #48 for my thoughts on how best to do this.

ml-evs commented 6 months ago

See #47