search

Solid-Energy-Systems / NewareNDA

Python module and command line tool for reading and converting Neware nda and ndax battery cycling data files.
BSD 3-Clause "New" or "Revised" License
15 stars 8 forks source link

Some aux data missing from (some) files #50

Closed Grimler91 closed 5 months ago

Grimler91 commented 6 months ago

Hi,

I have noticed that NewareNDA sometimes fails to extract all aux data, and instead just returns NaN after some point. Non-aux values work fine. Here is an example plot with capacity and aux temperature plotted with data from either an exported xlsx file, or from NewareNDA:

missing-data

As can be seen the aux temperature is missing in NewareNDA data after roughly cycle index 250. (I will send the data to Dan in private)

d-cogswell commented 6 months ago

The aux data seems to be stored in ndc version 5, which I don't think I've seen before. Does this come from a different machine, or did you upgrade software or something?

Grimler91 commented 6 months ago

Same machine, but I upgraded bts server & client in middle of November, to "BTS 8.0.1 20230531". Data I sent previously must have been with previous version, so that likely explains issues.

It is rather impressive then instead that newareNDA can (almost) handle a ndc version it was not made for :)

d-cogswell commented 6 months ago

Ok, that makes sense then. I think I have a fix, but I'm checking that it doesn't break any of my regression tests first. I hoped at first to write one function that would read everything, but it's becoming clear that ndax is actually a kludge of many different formats. Each version needs its own separate treatment.

d-cogswell commented 6 months ago

I pushed a commit to development that I hope fixes this issue. @Grimler91 can you do some testing and let me know if you find any issues?

Grimler91 commented 6 months ago

Haven't discovered any issues so far, development branch works well with ndax files I have, thanks!

d-cogswell commented 5 months ago

Fixed in 973bb54