search

Solid-Energy-Systems / NewareNDA

Python module and command line tool for reading and converting Neware nda and ndax battery cycling data files.
BSD 3-Clause "New" or "Revised" License
15 stars 8 forks source link

Logging active mass #59

Closed d-cogswell closed 4 months ago

d-cogswell commented 4 months ago

Extract active mass and return the result as logging info because it can be zero.

AdamOpps commented 4 months ago

@d-cogswell I committed adjustments to the mass logging and included remarks logging. I don't know how to formally request a review from you, so this will have to do!

vividh-garg commented 4 months ago

The position of all the data like barcode, start time, end time, remarks, active mass, step file name etc. are relative to the position of the word "BTS Client" in BTS 4000 nda files and not an absolute position.

AdamOpps commented 4 months ago

Interesting, I have not yet had a case where the absolute index didn't work for 4000 files, but I can make these adjustments! Increased compatibility is a good thing!

d-cogswell commented 4 months ago

@AdamOpps what are the active masses for the BTS 9000 files you emailed? I'm not sure your solution is returning the correct values, but I also don't have a version of BTSDA that will let me see the

@vividh-garg if you turn on logging, you see some client/server version info. Unfortunately, I don't think there is a universal solution that works for every file. Instead you need different solutions based on the nda file version.

AdamOpps commented 4 months ago

@AdamOpps what are the active masses for the BTS 9000 files you emailed? I'm not sure your solution is returning the correct values, but I also don't have a version of BTSDA that will let me see the

I am paraphrasing my email here: I am able to process those files with this code for the 9000 extraction and I can confirm it returns the expected values (10.8152mg) for active mass and remarks, at least on my end!

@vividh-garg Do you have a file that you would be willing to send to me or @d-cogswell where the absolute reference does not work? You could truncate the binary file before any actual cycling data begins, if you want to obscure sensitive information. If not, just the nda File version would also potentially be helpful.

d-cogswell commented 4 months ago

@AdamOpps thanks for confirming the mass. I made a few minor tweaks and I think this is good to merge.