Solid-Energy-Systems / NewareNDA

Python module and command line tool for reading and converting Neware nda and ndax battery cycling data files.
BSD 3-Clause "New" or "Revised" License
15 stars 8 forks source link

BTS85 charge/discharge capacity values are unrealistic #60

Closed vajeeston closed 3 months ago

vajeeston commented 4 months ago

Hi there!

Could you assist me in overcoming this issue? When I run the NewareNDA on the latest files generated from BTS85, the charge/discharge capacity values are unrealistic. However, when we open these files in BTSDA 8.0.0.526, the values appear normal (please refer to the attached figure). For your convenience, I have attached an example file to this message. I am eager to resolve this issue. Screenshot 2024-05-15 151953 BTS85-36-6-5-110-20240424.zip

d-cogswell commented 4 months ago

Hi @vajeeston it looks like you have a new file version that I haven't seen before. Thanks for sharing the file. It's probably easy to fix, but can you direct me to a version of BTSDA that will open this file?

vajeeston commented 4 months ago

Hi! As I have mentioned, this can open in BTSDA 8.0.0.526 and other versions. I have checked, and it works well with previous versions as well. Thank you for your support!

vajeeston commented 4 months ago

Few notes and updates:

It appears that there is a conversion factor at play here. For instance, when we multiply the voltage column by 1000, the voltage values are displayed correctly.

df1 = NewareNDA.read(nw_ndax_input_file_1, cycle_mode='auto') df1['Voltage'] = df1['Voltage'] 10000 df1['Charge_Capacity(mAh)'] = df1['Charge_Capacity(mAh)'] 1000000000 df1['Discharge_Capacity(mAh)'] = df1['Discharge_Capacity(mAh)'] * 1000000000

However, when multiplying the Charge_Capacity and Discharge_Capacity columns by 1000000000, the values are not only in a different order but also significantly different. Further testing reveals:

Testing with and without the data_interpolation function: With data interpolation function (see 'with_data_interpolation_fn.jpg'), the values undergo substantial changes. Without data interpolation function (see 'without_data_interpolation_fn.jpg'), the values appear promising but remain incorrect.

Thank you for your help!

with_data_interpolation_fn without_data_interpolation_fn

d-cogswell commented 4 months ago

Thanks, I got the file to open after installing BTS 8.0.1. It's a new version of ndc with the data packed slightly differently. I'm working on it.

d-cogswell commented 4 months ago

I think I have a solution in this pull request: #62

vajeeston commented 4 months ago

Is it possible to get the code?

d-cogswell commented 4 months ago

Yes, you can download the branch with this link: https://github.com/Solid-Energy-Systems/NewareNDA/archive/refs/heads/issue/60.zip

vajeeston commented 3 months ago

Hi!

Now the voltage values are correct, but, the charge and discharge capacity values are not correct. please see the figure. image

d-cogswell commented 3 months ago

Hi @vajeeston I checked the results from NewareNDA again and they look correct to me. You should compare either individual records, or a grouping by step number such as: df.groupby(['Cycle', 'Step']).last()

Comparing by cycle number can be confusing because Neware has several different options for how it assigns cycle numbers. I think you can reproduce what you are seeing in BTSDA by loading your file like this: df = NewareNDA.read('BTS85-36-6-5-110-20240424.ndax', software_cycle_number=False)

vajeeston commented 3 months ago

Thank you for your support! it's working fine!

d-cogswell commented 3 months ago

Hi @vajeeston would it be ok with you if I use your ndax file from this issue as a regression test for NewareNDA?

vajeeston commented 3 months ago

Hi Dan,

Ok no problem!


From: Dan Cogswell @.***> Sent: 31 May 2024 20:31:26 To: Solid-Energy-Systems/NewareNDA Cc: Vajeeston Ponniah; Mention Subject: Re: [Solid-Energy-Systems/NewareNDA] BTS85 charge/discharge capacity values are unrealistic (Issue #60)

Hi @vajeestonhttps://github.com/vajeeston would it be ok with you if I use your ndax file from this issue as a regression test for NewareNDA?

— Reply to this email directly, view it on GitHubhttps://github.com/Solid-Energy-Systems/NewareNDA/issues/60#issuecomment-2142785777, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANOBK4KYDXPLTP353NEWDF3ZFC6X5AVCNFSM6AAAAABHYFTWB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBSG44DKNZXG4. You are receiving this because you were mentioned.Message ID: @.***>