Minor Logging Functionality Rework - Align implementation to best practices

Solid-Energy-Systems / NewareNDA

Python module and command line tool for reading and converting Neware nda and ndax battery cycling data files.

BSD 3-Clause "New" or "Revised" License

15 stars 8 forks source link

Closed AdamOpps closed 2 months ago

AdamOpps commented 3 months ago

Intention:

Log to a specific logger labeled 'newarenda'. Common practice is for modules to log to a logger with the same name as its package. Currently, these scripts log to 'root' which inserts itself into the default logger for any application and is not recommended.
Include some warnings in the log where applicable.

Are there any other modifications to be made? Things to consider? EDITS + ADDITIONS:

Grimler91 commented 3 months ago

Would be nice to be able to set the log level with arg to NewareNDA-cli.py and NewareNDA.read() as well!

AdamOpps commented 3 months ago

Good idea! I'll add that to the list!