Solid-Energy-Systems / NewareNDA

Python module and command line tool for reading and converting Neware nda and ndax battery cycling data files.
BSD 3-Clause "New" or "Revised" License
17 stars 10 forks source link

Rework logging functionality. [Issue/66] #71

Closed AdamOpps closed 4 months ago

AdamOpps commented 6 months ago

NOTE: Moving forward, all log messages should be called from "logger". Example: logger.info('Good! This message is saved to name: newarenda) logging.info('Bad! This message is saved to name: root')

d-cogswell commented 6 months ago

Hi, I'm finally getting caught up here. This is a nice improvement! I noticed there are still some logging happening to root (the old way) for 'Active mass' and 'Remarks'. These should be changed to newarenda.

d-cogswell commented 6 months ago

I'm going to merge #68 and #70 while we continue working on this. I've already encountered the #68 issue in my own data processing.

AdamOpps commented 6 months ago

Sounds good. Sorry for my delay, I have been dealing with some personal things that have set me back a bit.