search

Solid-Energy-Systems / NewareNDA

Python module and command line tool for reading and converting Neware nda and ndax battery cycling data files.
BSD 3-Clause "New" or "Revised" License
17 stars 10 forks source link

Capacity and energy fields separated into charge and discharge #8

Closed d-cogswell closed 2 years ago

d-cogswell commented 2 years ago

Should we make this change?

yliu-electra commented 2 years ago

Looks good to me. So previously those capacities were calculated (or read) separately but combined to output only one value? They are mutually exclusive at any time right? Does NDA store them natively in two variables or one variable, in other words, were them native or derived quantities?

Usually, I don't see a need in changing those. But it may help in more complex cases such as in the 'sim' status.

On Fri, Jun 24, 2022 at 1:11 PM Dan Cogswell @.***> wrote:

Should we make this change?

You can view, comment on, or merge this pull request online at:

https://github.com/Solid-Energy-Systems/NewareNDA/pull/8 Commit Summary

File Changes

(1 file https://github.com/Solid-Energy-Systems/NewareNDA/pull/8/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/Solid-Energy-Systems/NewareNDA/pull/8, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZDN4TSSCQG7HCTFFFTWTI3VQYB6FANCNFSM5ZYXWC4Q . You are receiving this because your review was requested.Message ID: @.***>

--

Yuxiang Liu​​ | Email: @.*** Website: www.electravehicles.com Direct Line: 970 402‑6821 Main Line: +1 (617) 313‑7842 Address: 110 K Street, Suite 330, Boston, MA 02127 http://www.electravehicles.com/ [image: LinkedIn] https://www.linkedin.com/company/electra-vehicles-inc/ [image: Twitter] http://twitter.com/ElectraVehicles https://www.electravehicles.com/eve-ai-adaptive-controls

Yuxiang Liu | Email: @.*** Website: www.electravehicles.com Direct Line: 970 402-6821 Main Line: +1 (617) 313-7842 Address: 110 K Street, Suite 330, Boston, MA 02127

d-cogswell commented 2 years ago

Hi @yliu-electra , charge and discharge capacity (and energy) are stored as separate fields in the nda format, but I had been adding them together to match the Excel output. We also hope keeping the original splitting will help with 'sim'.

yliu-electra commented 2 years ago

I will give that a try and let you know if there are any issues.

Thanks

On Fri, Jun 24, 2022 at 3:14 PM Dan Cogswell @.***> wrote:

Hi @yliu-electra https://github.com/yliu-electra , charge and discharge capacity (and energy) are stored as separate fields in the nda format, but I had been adding them together to match the Excel output. We also hope keeping the original splitting will help with 'sim'.

— Reply to this email directly, view it on GitHub https://github.com/Solid-Energy-Systems/NewareNDA/pull/8#issuecomment-1165945814, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZDN4TQCWUBHNK2VNI6FWJTVQYQMJANCNFSM5ZYXWC4Q . You are receiving this because you were mentioned.Message ID: @.***>

--

Yuxiang Liu​​ | Email: @.*** Website: www.electravehicles.com Direct Line: 970 402‑6821 Main Line: +1 (617) 313‑7842 Address: 110 K Street, Suite 330, Boston, MA 02127 http://www.electravehicles.com/ [image: LinkedIn] https://www.linkedin.com/company/electra-vehicles-inc/ [image: Twitter] http://twitter.com/ElectraVehicles https://www.electravehicles.com/eve-ai-adaptive-controls

Yuxiang Liu | Email: @.*** Website: www.electravehicles.com Direct Line: 970 402-6821 Main Line: +1 (617) 313-7842 Address: 110 K Street, Suite 330, Boston, MA 02127