SonnenladenGmbH / APsystems-EZ1-API-HomeAssistant

The APsystems EZ1 Integration offers a streamlined interface for interacting with the local API of APsystems EZ1 Microinverters using Home Assistant.
MIT License
77 stars 11 forks source link

added debouncing of today's energy sensors #38

Closed patman15 closed 1 month ago

patman15 commented 2 months ago

Hi!

I know you do not want to change the code until the pull-request to core is through, but still to document the enhancement, here it is. This changes solves the issue that the inverter restarts "daily production" in case there is power outage or not enough sunlight to keep the inverter awake. Value do increase until midnight and then fall back to zero. Still values are not available when the inverter is offline, so behaviour is similar to before the change. Tested in my setup. Maybe you find it useful, it helped me a lot for the energy statistics which were otherwise messed up.

mawoka-myblock commented 2 months ago

Hey, thank you very much. I've reworked most of the code to use SensorDescriptions in the PR (https://github.com/home-assistant/core/pull/114531), so this won't be applicable 1:1. Because of that, I'll keep this PR open, as I just want to archive this repo, but at HA's pace regarding PRs, this will be in ~2 years.

patman15 commented 2 months ago

Do you want me to switch over to the code of the PR and fix it there as well?

mawoka-myblock commented 2 months ago

If you want, sure! Can you just push to a PR like that?

mawoka-myblock commented 1 month ago

The integration is now merged into HA core. Feel free to create a PR there.

patman15 commented 1 month ago

The integration is now merged into HA core. Feel free to create a PR there.

Cool, congratulations to you. I will update my test stage and then have a look. Currently, I'm too happy with my running setup. :smile:

mawoka-myblock commented 1 month ago

Sure, no problem. This integration will keep working as it does now. I'll archive it and put a out some reminders to migrate to the core integration once it'll be available in a stable release