search

SpartanJ / ecode

Lightweight multi-platform code editor designed for modern hardware with a focus on responsiveness and performance.
MIT License
940 stars 13 forks source link

FR: Open files from opened folder improvement #254

Closed ghost closed 7 months ago

ghost commented 7 months ago

Assuming the number of files in the folder is very large and the users know exactly which files they want to open, should there be a text box so users could enter the name of the file they want to open? Think a bit further: should that text box allow the users to search for files whose names match the name or the patterns they entered?

ghost commented 7 months ago

if i need to open many files i'll drag the files to ecode.

I will do like you.

ghost commented 7 months ago

@SpartanJ What do you think about this proposal? I want to know your opinion, even though I still think your way works better.

SpartanJ commented 7 months ago

It makes sense as an improvement for the file picker dialog, I don't consider it particularly important. This is the best way to do it IMO (plus accepting glob patterns):

https://github.com/SpartanJ/ecode/assets/650416/18d5b235-77a6-4f57-8001-e9a1f41778df

ghost commented 7 months ago

It makes sense as an improvement for the file picker dialog, I don't consider it particularly important. This is the best way to do it IMO (plus accepting glob patterns):

2024-04-15_14-56-58.mp4

So you want to implement the feature in the Open File dialog instead? Because in this FR, I'm talking about opened folder. It will be something like a search button next to the build setting button. Click on it and enter the file name or patterns into the text box to search for files in the opened folder. What do you think about it? @SpartanJ

Update: It's fine to implement the feature in the Open File dialog to keep the open folder feature simple. But there should be a way to synchronize the location in Open File with the currently opened folder. See: https://github.com/SpartanJ/ecode/issues/255