search

SpartanJ / ecode

Lightweight multi-platform code editor designed for modern hardware with a focus on responsiveness and performance.
MIT License
940 stars 13 forks source link

Unsaved mark exceeds tabwidth #287

Closed NullPlane closed 4 months ago

NullPlane commented 4 months ago

Idk how to classify this. In short: If the filename is very long the * asterisk vanishes to mark it unsaved.

SpartanJ commented 4 months ago

Ohh, because the * goes at the end of the filename, so it gets cut, I didn't think about it when I added the ellipsis and never noticed. Let me think how to solve it. Maybe it's time to remove the asterisk all over.

SpartanJ commented 4 months ago

I removed the asterisk in favor of a visual color indicator: Screenshot_20240630_203355

I think it looks better but it worries me a little if color blind people can perceive it (for me it's perfectly obvious but I'm not color blind).

I might add a circle like in vscode but I'm not convinced.

SpartanJ commented 4 months ago

Issue #69 is a request for a better distinction for saved and unsaved files, so this change is relevant for both issues.

SpartanJ commented 4 months ago

Mmh changed my mind, current version: Screenshot_20240701_214746

NullPlane commented 4 months ago

looks fresh. What'll be the var in the ui styling?

SpartanJ commented 4 months ago

The UI can be styled with CSS as always. You can create a custom theme or use the --css command parameter. Here's the new CSS.