search

SpartanJ / ecode

Lightweight multi-platform code editor designed for modern hardware with a focus on responsiveness and performance.
MIT License
938 stars 13 forks source link

View PDF inside editor #322

Closed ghost closed 2 months ago

ghost commented 2 months ago

Very heavy dependency with very little gain (as you said in #168). No, I don't think so. I think you will only need the PDFium shared library or similar library. It should be implemented as a plugin, that is, the users will need to manually download it to install, since it's not part of the binary release packages. Similar to how texteditor.pro is doing. ecode supports plugins but there are currently only a handful of them. The plugin infrastructure could be exploited to do more.

SpartanJ commented 2 months ago

I don't understand what was your intention creating and closing issues right after creating them, several of them over topics already discussed. You knew that this feature was already discussed and rejected. If you wanted to give your opinion the issue is still there, you even referenced it. Please be mindful before creating new issues.

Curculigo commented 2 months ago

I don't understand what was your intention creating and closing issues right after creating them, several of them over topics already discussed. You knew that this feature was already discussed and rejected. If you wanted to give your opinion the issue is still there, you even referenced it. Please be mindful before creating new issues.

I want to tell him the same thing. He closed the issues too soon.

Curculigo commented 2 months ago

I found this project on Github:

https://github.com/rofl0r/SDLBook

It's using libmupdf and djvulibre. I think it's definitely possible to add a PDF viewer to ecode. But I don't mind having to use an external PDF viewer.

SpartanJ commented 2 months ago

It's possible but it's a lot of work, much more than you might imagine. mupdf and sumatrapdf are great but its licenses are not very friendly with ecode license, integrating any pdf viewer into an OpenGL context is a lot of work, distributing the pdf shared library dependency for all the platforms support is also a lot of work. I need people to understand that my time is very limited and I'm the sole maintainer of the project which is already huge. These kinds of things are way off my priorities. My number one priority right now is to implement debugging support and didn't have time to even start because I get distracted with smaller / quicker to implement features and bug fixes. These kind of feature requests make sense as a plugin provided by a new collaborator who's willing to take the time and effort for such a endeavour.