search

SpatioTemporal / STAREPandas

STAREpandas adds SpatioTemporal Adaptive Resolution Encoding (STARE) support to pandas DataFrames. https://starepandas.readthedocs.io/en/latest/
MIT License
4 stars 1 forks source link

Fixed issue 144. Added nom_res_str to correctly capture intent of nom… #146

Closed michaelleerilee closed 1 year ago

michaelleerilee commented 1 year ago

…_res=None. Propagated changes through tests and some granule readers. Added set_nom_res() method to base Granule class.

Ref. #144

michaelleerilee commented 1 year ago

@NiklasPhabian We should bump version and create a release if this update is acceptable.

michaelleerilee commented 1 year ago

Note I found and corrected a bunch of errors when running pytest from code not updated since we started adding nom_res to variable names.

michaelleerilee commented 1 year ago

I'm getting a clean pytest locally, but pytest is only finding 95 items, not 96.

NiklasPhabian commented 1 year ago

by clean pytest, do you mean passing all tests? That would be curious because the GH actions and my local fails two tests. Both possibly caused by pandas>=2.0.0

NiklasPhabian commented 1 year ago

uuuf. Indeed, this was caused by pandas. Now unfortunately, pickled dataframes are not compatible between versions. I.e. we would have to re-pod data if we switched to pandas>=2.0.

michaelleerilee commented 1 year ago

Is there a path for reading pickles at one version and writing to a new version?

Apparently the pickle lib can be instructed which protocol to use.

Ah, but we're talking about serializing dataframes...

michaelleerilee commented 1 year ago

https://pandas.pydata.org/docs/reference/api/pandas.read_pickle.html says that read_pickle is compatible back to pandas 0.20.3...

NiklasPhabian commented 1 year ago

I'm getting a clean pytest locally, but pytest is only finding 95 items, not 96.

we had been skipping one of the examples

NiklasPhabian commented 1 year ago

@michaelleerilee @mbauer288 can you verify that my edits do not break your usecases?