for any inplace=False, we should return a sdf, not a series

SpatioTemporal / STAREPandas

STAREpandas adds SpatioTemporal Adaptive Resolution Encoding (STARE) support to pandas DataFrames. https://starepandas.readthedocs.io/en/latest/

MIT License

4 stars 1 forks source link

for any inplace=False, we should return a sdf, not a series #99

Closed NiklasPhabian closed 2 years ago

NiklasPhabian commented 2 years ago

We have functions that have an inplace toggle. If inplace = True, they modifiy the dataframe inplace, if false, they return a trixel series. We need to change this so they will either return a copy of the whole dataframe or modify the df inplace.

We implemented this behavior correctly in:

set_sids
set_trixels

But incorrectly in:

split_antimeridian
to_stare_resolution
clear_to_resolution
to_stare_singleres