fix(#174): Fixes simulate and capture mode checker logic

[tommysitu]

Hi @lordofthejars, I'd recommend you to re-fork hoverfly-java project. It has been slimmed down to 2MB for easy cloning.

[lordofthejars]

ok, I will do but can you merge this PR? Or this is a blocker? I mention this because I'd need this fix ASAP :)

[tommysitu]

I deliberately changed the way it looks for test resource files using classloader instead of hardcoded relative path. But this PR will revert it back. I think the problem is that previously recorded file is by default stored under the hoverfly folder, and I forgot to append it in when I did the change.

We can keep my change and fix your problem by appending hoverfly/ to the recordFile input

[tommysitu]

I can fix it quickly

[lordofthejars]

Sure. Thanks.

[tommysitu]

This will fix it: https://github.com/SpectoLabs/hoverfly-java/commit/ab38d53101b8a886b777d84706de912bf9b1174a

My bad, do you need it in a release version?

[codecov-io]

Codecov Report

Merging #175 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff            @@
##             master    #175   +/-   ##
========================================
  Coverage      83.7%   83.7%           
  Complexity      595     595           
========================================
  Files            70      70           
  Lines          1731    1731           
  Branches         91      91           
========================================
  Hits           1449    1449           
  Misses          240     240           
  Partials         42      42

Impacted Files	Coverage Δ	Complexity Δ
...va/io/specto/hoverfly/junit/rule/HoverflyRule.java	82.65% <100%> (ø)	42 <2> (ø)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6726b68...6d9037a. Read the comment docs.

[tommysitu]

I will release this patch now, as it causes problems with existing users

[lordofthejars]

No worries, I can wait until Monday :)

[tommysitu]

@lordofthejars I think your PR was a better fix, but it's not easy to rebase it on the latest master. I will redo what you did to fix issue #200