SpikeInterface / probeinterface

Python package to handle probe layout, geometry and wiring to device.
MIT License
54 stars 45 forks source link

BEP032 support #309

Open bendichter opened 4 days ago

bendichter commented 4 days ago

We're working on BIDS Enhancement Proposal 32 (BEP32) https://github.com/bids-standard/bids-specification/pull/1705 which requires probe layout specification capabilities. After evaluating ProbeInterface for this purpose, we've considered three approaches:

  1. Referencing ProbeInterface atlases directly
  2. Including ProbeInterface JSON files within datasets
  3. Adding ProbeInterface-inspired columns to existing electrodes.tsv and probes.tsv tables

We've decided to proceed with option 3 as it best aligns with BIDS' existing layout, form, and infrastructure. Moving forward, we'd like to develop bidirectional conversion utilities between ProbeInterface JSON files and the BIDS columnar structure.

While we're actively developing this on the BIDS side, we're still determining the best location for the conversion code. It might be sufficient to simply reference the BIDS implementation in the ProbeInterface documentation. I'm creating this issue primarily to keep the ProbeInterface development team informed of these developments and potential future integration needs.

samuelgarcia commented 2 days ago

Hi Ben, thanks for the update. Please also notes that we have a bids BEP32 reader in spikeinterface here : https://github.com/SpikeInterface/spikeinterface/blob/main/src/spikeinterface/extractors/bids.py it was implemented a while ago and we should certainly update it!