Closed pvarry closed 2 years ago
Hello, any news on this @jmfayard @LouisCAD ?
Hello, I just made an experiment to see if we can avoid this unwanted unused comment, and it should work, so I'll try to implement it soon.
We should also be able to factor these usages in when looking for available versions.
Thanks for raising this back.
The 0.41.0-SNAPSHOT
version contains the change that addresses this issue.
I'll publish a release this weekend or next week.
Please don't override version 0.40.2-SNAPSHOT
@louiscad
Some people use it since months to get dependencies updates in their versions catalog
I think the 0.40.2 release did remove the related snapshot, not this 0.41.0 snapshot.
OK, but apparently the version is still not being updated by refreshVersions? I expect it to be as it is indeed used.
@mcpiroman Wrong issue, or you're on an older version?
I mean I have
[versions]
skiko = "0.7.42"
[libraries]
skiko = { module = "org.jetbrains.skiko:skiko", version.ref = "skiko" }
Then I do api("org.jetbrains.skiko:skiko-awt-runtime-${targetOs}-${targetArch}:${versionFor("org.jetbrains.skiko:skiko:_")}")
Then the update comments are not generated for skiko.
Is this maybe some other issue? I use 0.51.0
Are you using configureOnDemand?
I don't.
🐛 Describe the bug
Version in
versions.properties
get unused when it's only used withversionFor()
.⚠️ Current behavior
My versions get
unused
✅ Expected behavior
Do not add
unused
when it's used byversionFor()
💣 Steps to reproduce
version.androidx.compose.compiler=1.1.1
composeOptions
inbuild.gradle.kts
:./gradlew refreshVersions
and see Compose Compiler get an unused inversions.properties
Note: Compose Compiler need to be used only in
versionFor
to be annotated withunused
📱 Tech info
PS: Thanks for this wonderful library