search

SpockBotMC / SpockBot

High level Python framework for building Minecraft clients and bots.
MIT License
198 stars 47 forks source link

Feature/auth refurbish #186

Closed txomon closed 8 years ago

txomon commented 8 years ago

This work has taken ages :(, but I want to submit it before it's refactored by someone else..

nickelpro commented 8 years ago

I like a lot of this code but really want another set of eyes on it since I have infamously poor judgement of these things and it touches some essential core stuff. @Gjum or @gamingrobot if one of you would read over the final changes and just give me a signoff or concerns I would feel a lot better merging

gamingrobot commented 8 years ago

The only comment I have is doing ploader.provides('Auth', self) when self also contains handle_ functions that could be called outside of the class. Other than that, it looks good to merge.

nickelpro commented 8 years ago

This has sat here for literally forever. I'm following the classic SpockBot philosophy of "Fuck It. Merging"