search

SpoonLabs / gumtree-spoon-ast-diff

Computes the AST difference (aka edit script) between two Spoon Java source code abstract syntax trees
http://hal.archives-ouvertes.fr/hal-01054552
Apache License 2.0
161 stars 42 forks source link

fix some "no AST change" when there are syntax errors #299

Closed andre15silva closed 9 months ago

andre15silva commented 11 months ago

In cases where there are some syntax errors, gumtree-spoon-ast-diff outputs "no AST change"

This PR fixes that. Right now, only the most serious cases are fixed. If there are subtle syntax errors like missing a ";" or ")" and the rest matches, it will still output "no AST change" :/

monperrus commented 9 months ago

should we unwip and merge?

andre15silva commented 9 months ago

Sure @monperrus !

Note that the bug is not totally fixed since there are still cases where, even if one of the versions has syntax errors, "no AST change" is outputted. See https://github.com/SpoonLabs/gumtree-spoon-ast-diff/issues/305

monperrus commented 9 months ago

thanks @andre15silva