search

StageCentral / backstage-artifactory-plugin

https://stagecentral.io
4 stars 1 forks source link

Artifactory API calls in infinite loop #1

Closed DominikBucko closed 2 months ago

DominikBucko commented 8 months ago

Hi, I was trying to use the plugin and I noticed that it is spamming API requests for artifactory. Upon further investigation, I noticed, that it is because of useEffect hook does not have empty dependency array specified. This causes the effect (AF call) to be executed upon every render.

I can do a PR, as I already tested the fix locally in my instance.

ssliman commented 2 months ago

@antweiss any update on this?

antweiss commented 2 months ago

Hi @DominikBucko @ssliman , guess I totally missed this in the mess we've been through. Will look into it tomorrow.

antweiss commented 2 months ago

PR merged. Thanks! Version 0.1.4 of the frontend plugin released to npmjs

antweiss commented 2 months ago

thank you