search

Stanford / WMD

WebAuth Module for Drupal
WMD
GNU General Public License v2.0
9 stars 9 forks source link

Review hook_boot redirect to HTTPS #91

Open mistermarco opened 12 years ago

mistermarco commented 12 years ago

hook_boot redirects the user to an HTTPS version of the site if he/she accesses the site through HTTP and has an WMDsecureLogin cookie (a flag that indicates they logged in at some point).

During the redirect, the URL is modified and the location is turned into one that uses ?q= However, that doesn't seem to keep any of the other query parameters. Is this on purpose? Why not just use request_uri?

mistermarco commented 12 years ago

Also note the way we check for HTTPS being empty. Should we check to see if it's set first?